If you notice some outdated information please let us know!
FAIL
The final review score is indicated as a percentage. The percentage is calculated as Achieved Points due to MAX Possible Points. For each element the answer can be either Yes/No or a percentage. For a detailed breakdown of the individual weights of each question, please consult this document.
Very simply, the audit looks for the following declarations from the developer's site. With these declarations, it is reasonable to trust the smart contracts.
This report is for informational purposes only and does not constitute investment advice of any kind, nor does it constitute an offer to provide investment advisory or other services. Nothing in this report shall be considered a solicitation or offer to buy or sell any security, token, future, option or other financial instrument or to offer or provide any investment advice or service to any person in any jurisdiction. Nothing contained in this report constitutes investment advice or offers any opinion with respect to the suitability of any security, and the views expressed in this report should not be taken as advice to buy, sell or hold any security. The information in this report should not be relied upon for the purpose of investing. In preparing the information contained in this report, we have not taken into account the investment needs, objectives and financial circumstances of any particular investor. This information has no regard to the specific investment objectives, financial situation and particular needs of any specific recipient of this information and investments discussed may not be suitable for all investors.
Any views expressed in this report by us were prepared based upon the information available to us at the time such views were written. The views expressed within this report are limited to DeFiSafety and the author and do not reflect those of any additional or third party and are strictly based upon DeFiSafety, its authors, interpretations and evaluation of relevant data. Changed or additional information could cause such views to change. All information is subject to possible correction. Information may quickly become unreliable for various reasons, including changes in market conditions or economic circumstances.
This completed report is copyright (c) DeFiSafety 2023. Permission is given to copy in whole, retaining this copyright label.
This section looks at the code deployed on the Mainnet that gets reviewed and its corresponding software repository. The document explaining these questions is here.
1. Are the executing code addresses readily available? (%)
Guidance: 100% Clearly labelled and on website, docs or repo, quick to find 70% Clearly labelled and on website, docs or repo but takes a bit of looking 40% Addresses in mainnet.json, in discord or sub graph, etc 20% Address found but labelling not clear or easy to find 0% Executing addresses could not be found
2. Is the code actively being used? (%)
Activity is 30 transactions a day on contract PeakStaking, as indicated in the Appendix.
3. Is there a public software repository? (Y/N)
Is there a public software repository with the code at a minimum, but also normally test and scripts. Even if the repository was created just to hold the files and has just 1 transaction, it gets a "Yes". For teams with private repositories, this answer is "No"
4. Is there a development history visible? (%)
With 24 commits and 1 branch, this is clearly not a healthy software repository.
This metric checks if the software repository demonstrates a strong steady history. This is normally demonstrated by commits, branches and releases in a software repository. A healthy history demonstrates a history of more than a month (at a minimum).
5. Is the team public (not anonymous)? (Y/N)
There is not any evidence of any public team members.
For a "Yes" in this question, the real names of some team members must be public on the website or other documentation (LinkedIn, etc). If the team is anonymous, then this question is a "No".
This section looks at the software documentation. The document explaining these questions is here.
6. Is there a whitepaper? (Y/N)
7. Are the basic software functions documented? (Y/N)
There are no evident documentations of basic software functions.
8. Does the software function documentation fully (100%) cover the deployed contracts? (%)
There are no evident documentations of basic software functions.
9. Are there sufficiently detailed comments for all functions within the deployed contract code (%)
The Comments to Code (CtC) ratio is the primary metric for this score.
10. Is it possible to trace from software documentation to the implementation in code (%)
There are no evident documentations of basic software functions, and therefore no links with code implementation.
11. Full test suite (Covers all the deployed code) (%)
With TtC of 28%, they do not have a barely adequate test suite.
This score is guided by the Test to Code ratio (TtC). Generally a good test to code ratio is over 100%. However the reviewers best judgement is the final deciding factor.
12. Code coverage (Covers all the deployed lines of code, or explains misses) (%)
Code coverage is indicated by the Quantstamp security audit.
13. Scripts and instructions to run the tests? (Y/N)
There are no evident signs of script or testing instructions.
14. Report of the results (%)
There are result reports indicated by the Quantstamp security audit.
15. Formal Verification test done (%)
16. Stress Testing environment (%)
This section looks at the 3rd party software audits done. It is explained in this document.
17. Did 3rd Party audits take place? (%)
18. Is the bug bounty acceptable high? (%)
There is no evident bug bounty.
This section covers the documentation of special access controls for a DeFi protocol. The admin access controls are the contracts that allow updating contracts or coefficients in the protocol. Since these contracts can allow the protocol admins to "change the rules", complete disclosure of capabilities is vital for user's transparency. It is explained in this document.
19. Can a user clearly and quickly find the status of the access controls (%)
There is no evident documentation that reveals the status of the admin controls.
20. Is the information clear and complete (%)
There is no evident documentation that reveals the status of the admin controls.
21. Is the information in non-technical terms that pertain to the investments (%)
There is no evident documentation that reveals the status of the admin controls.
22. Is there Pause Control documentation including records of tests (%)
There is no evident documentation that reveals the status of the admin controls.
1pragma solidity 0.5.17;
2
3import "@openzeppelin/contracts/ownership/Ownable.sol";
4import "../interfaces/Comptroller.sol";
5import "../interfaces/PriceOracle.sol";
6import "../interfaces/CERC20.sol";
7import "../interfaces/CEther.sol";
8import "../Utils.sol";
9
10contract CompoundOrder is Utils(address(0), address(0), address(0)), Ownable {
11 // Constants
12 uint256 internal constant NEGLIGIBLE_DEBT = 100; // we don't care about debts below 10^-4 USDC (0.1 cent)
13 uint256 internal constant MAX_REPAY_STEPS = 3; // Max number of times we attempt to repay remaining debt
14 uint256 internal constant DEFAULT_LIQUIDITY_SLIPPAGE = 10 ** 12; // 1e-6 slippage for redeeming liquidity when selling order
15 uint256 internal constant FALLBACK_LIQUIDITY_SLIPPAGE = 10 ** 15; // 0.1% slippage for redeeming liquidity when selling order
16 uint256 internal constant MAX_LIQUIDITY_SLIPPAGE = 10 ** 17; // 10% max slippage for redeeming liquidity when selling order
17
18 // Contract instances
19 Comptroller public COMPTROLLER; // The Compound comptroller
20 PriceOracle public ORACLE; // The Compound price oracle
21 CERC20 public CUSDC; // The Compound USDC market token
22 address public CETH_ADDR;
23
24 / Instance variables
25 uint256 public stake;
26 uint256 public collateralAmountInUSDC;
27 uint256 public loanAmountInUSDC;
28 uint256 public cycleNumber;
29 uint256 public buyTime; // Timestamp for order execution
30 uint256 public outputAmount; // Records the total output USDC after order is sold
31 address public compoundTokenAddr;
32 bool public isSold;
33 bool public orderType; // True for shorting, false for longing
34 bool internal initialized;
35
36
37 constructor() public {}
38
39 function init(
40 address _compoundTokenAddr,
41 uint256 _cycleNumber,
42 uint256 _stake,
43 uint256 _collateralAmountInUSDC,
44 uint256 _loanAmountInUSDC,
45 bool _orderType,
46 address _usdcAddr,
47 address payable _kyberAddr,
48 address _comptrollerAddr,
49 address _priceOracleAddr,
50 address _cUSDCAddr,
51 address _cETHAddr
52 ) public {
53 require(!initialized);
54 initialized = true;
55
56 / Initialize details of order
57 require(_compoundTokenAddr != _cUSDCAddr);
58 require(_stake > 0 && _collateralAmountInUSDC > 0 && _loanAmountInUSDC > 0); // Validate inputs
59 stake = _stake;
60 collateralAmountInUSDC = _collateralAmountInUSDC;
61 loanAmountInUSDC = _loanAmountInUSDC;
62 cycleNumber = _cycleNumber;
63 compoundTokenAddr = _compoundTokenAddr;
64 orderType = _orderType;
65
66 COMPTROLLER = Comptroller(_comptrollerAddr);
67 ORACLE = PriceOracle(_priceOracleAddr);
68 CUSDC = CERC20(_cUSDCAddr);
69 CETH_ADDR = _cETHAddr;
70 USDC_ADDR = _usdcAddr;
71 KYBER_ADDR = _kyberAddr;
72 usdc = ERC20Detailed(_usdcAddr);
73 kyber = KyberNetwork(_kyberAddr);
74
75 // transfer ownership to msg.sender
76 _transferOwnership(msg.sender);
77 }
78
79 /**
80 * @notice Executes the Compound order
81 * @param _minPrice the minimum token price
82 * @param _maxPrice the maximum token price
83 */
Comments to Code: 335 / 304 = 110 %
Tests to Code: 84 / 304 = 28 %