If you notice some outdated information please let us know!
FAIL
The final review score is indicated as a percentage. The percentage is calculated as Achieved Points due to MAX Possible Points. For each element the answer can be either Yes/No or a percentage. For a detailed breakdown of the individual weights of each question, please consult this document.
Very simply, the audit looks for the following declarations from the developer's site. With these declarations, it is reasonable to trust the smart contracts.
This report is for informational purposes only and does not constitute investment advice of any kind, nor does it constitute an offer to provide investment advisory or other services. Nothing in this report shall be considered a solicitation or offer to buy or sell any security, token, future, option or other financial instrument or to offer or provide any investment advice or service to any person in any jurisdiction. Nothing contained in this report constitutes investment advice or offers any opinion with respect to the suitability of any security, and the views expressed in this report should not be taken as advice to buy, sell or hold any security. The information in this report should not be relied upon for the purpose of investing. In preparing the information contained in this report, we have not taken into account the investment needs, objectives and financial circumstances of any particular investor. This information has no regard to the specific investment objectives, financial situation and particular needs of any specific recipient of this information and investments discussed may not be suitable for all investors.
Any views expressed in this report by us were prepared based upon the information available to us at the time such views were written. The views expressed within this report are limited to DeFiSafety and the author and do not reflect those of any additional or third party and are strictly based upon DeFiSafety, its authors, interpretations and evaluation of relevant data. Changed or additional information could cause such views to change. All information is subject to possible correction. Information may quickly become unreliable for various reasons, including changes in market conditions or economic circumstances.
This completed report is copyright (c) DeFiSafety 2023. Permission is given to copy in whole, retaining this copyright label.
This section looks at the code deployed on the Mainnet that gets reviewed and its corresponding software repository. The document explaining these questions is here.
1. Are the executing code addresses readily available? (%)
They are available at website https://developers.paraswap.network/smartcontracts as indicated in the Appendix.
2. Is the code actively being used? (%)
Activity is 1000 transactions a day on contract AugustusSwapperV4, as indicated in the Appendix.
3. Is there a public software repository? (Y/N)
GitHub: https://github.com/paraswap
Is there a public software repository with the code at a minimum, but also normally test and scripts. Even if the repository was created just to hold the files and has just 1 transaction, it gets a "Yes". For teams with private repositories, this answer is "No"
4. Is there a development history visible? (%)
With 475 commits and 31 branches, this is a very healthy software repository.
This metric checks if the software repository demonstrates a strong steady history. This is normally demonstrated by commits, branches and releases in a software repository. A healthy history demonstrates a history of more than a month (at a minimum).
5. Is the team public (not anonymous)? (Y/N)
Public team info can be found at https://www.linkedin.com/company/paraswap.
For a "Yes" in this question, the real names of some team members must be public on the website or other documentation (LinkedIn, etc). If the team is anonymous, then this question is a "No".
This section looks at the software documentation. The document explaining these questions is here.
7. Are the basic software functions documented? (Y/N)
Robust API documentation at https://developers.paraswap.network/
8. Does the software function documentation fully (100%) cover the deployed contracts? (%)
ParaSwap has in-depth API documentation that covers every token price retrieval and swap functions at https://developers.paraswap.network/api/build-parameters-for-transaction-builder-only and the rest of the "Price API" section.
9. Are there sufficiently detailed comments for all functions within the deployed contract code (%)
The Comments to Code (CtC) ratio is the primary metric for this score.
10. Is it possible to trace from software documentation to the implementation in code (%)
ParaSwap's API documentation includes robust code implementation tracing as seen in https://developers.paraswap.network/api/build-parameters-for-transaction-builder-only
11. Full test suite (Covers all the deployed code) (%)
This score is guided by the Test to Code ratio (TtC). Generally a good test to code ratio is over 100%. However the reviewers best judgement is the final deciding factor.
12. Code coverage (Covers all the deployed lines of code, or explains misses) (%)
Lack of testing and code coverage in their multiple audits.
13. Scripts and instructions to run the tests? (Y/N)
You can find instructions to run rests at the bottom of https://github.com/paraswap/paraswap-sdk.
14. Report of the results (%)
No test report evident in their GitHub repository.
15. Formal Verification test done (%)
No evidence of a ParaSwap Formal Verification test was found in their documentation or in web searches.
16. Stress Testing environment (%)
No evidence of ParaSwap test-net smart contract usage has been found in their documentation.
This section looks at the 3rd party software audits done. It is explained in this document.
17. Did 3rd Party audits take place? (%)
18. Is the bug bounty acceptable high? (%)
No evidence of a ParaSwap Bug Bounty program was found in their documentation or in web searches.
This section covers the documentation of special access controls for a DeFi protocol. The admin access controls are the contracts that allow updating contracts or coefficients in the protocol. Since these contracts can allow the protocol admins to "change the rules", complete disclosure of capabilities is vital for user's transparency. It is explained in this document.
19. Can a user clearly and quickly find the status of the access controls (%)
No admin access control information was found in the ParaSwap documentation.
20. Is the information clear and complete (%)
No access control or governance information was found in the ParaSwap documentation.
21. Is the information in non-technical terms that pertain to the investments (%)
No admin access control information was found in the ParaSwap documentation.
22. Is there Pause Control documentation including records of tests (%)
No evidence of a Pause Control or similar function in ParaSwap's documentation and GitHub repository.
1import axios, { AxiosError, AxiosRequestConfig } from 'axios';
2import * as qs from 'qs';
3import * as _ from 'lodash';
4import Web3 from 'web3';
5import type { SendOptions } from 'web3-eth-contract';
6
7import {
8 Adapters,
9 Address,
10 AddressOrSymbol,
11 Allowance,
12 APIError,
13 BuildOptions,
14 NetworkID,
15 PriceString,
16 RateOptions,
17 Transaction,
18 OptimalRatesWithPartnerFees,
19} from './types';
20
21import ERC20_ABI = require('./abi/erc20.json');
22
23import AUGUSTUS_ABI = require('./abi/augustus-v4.json');
24
25import { Token } from './lib/token';
26import { NULL_ADDRESS, TransactionBuilder } from './lib/transaction-builder';
27import {
28 SwapSide,
29 latestAugustusVersion,
30 AdapterAugustusVersionMap,
31} from './constants';
32
33const API_URL = 'https://apiv4.paraswap.io/v2';
34
35export class ParaSwap {
36 adapters?: Adapters;
37 tokens: Token[] = [];
38
39 constructor(
40 private network: NetworkID = 1,
41 private apiURL: string = API_URL,
42 public web3Provider?: any,
43 ) {
44 if (web3Provider && !web3Provider.eth) {
45 this.web3Provider = new Web3(web3Provider);
46 }
47 }
48
49 setWeb3Provider(web3Provider: any) {
50 if (!web3Provider.eth) {
51 this.web3Provider = new Web3(web3Provider);
52 } else {
53 this.web3Provider = web3Provider;
54 }
55 return this;
56 }
57
58 private handleAPIError(e: AxiosError): APIError {
59 if (e.response) {
60 const { data, status } = e.response!;
61 return { status, message: data.error, data };
62 }
63 return new Error(e.message);
64 }
65
66 async getTokens() {
67 try {
68 const tokensURL = `${this.apiURL}/tokens/${this.network}`;
69 const { data } = await axios.get(tokensURL);
70 this.tokens = (data.tokens as Token[]).map(
71 t =>
72 new Token(
73 t.address,
74 t.decimals,
75 t.symbol,
76 t.tokenType,
77 t.mainConnector,
78 t.connectors,
79 t.network,
80 t.img,
81 ),
82 );
83 return this.tokens;
84 } catch (e) {
85 return this.handleAPIError(e);
86 }
87 }
88
89 async getAdapters() {
90 try {
91 const { data } = await axios.get(
92 `${this.apiURL}/adapters/${this.network}`,
93 );
94
95 this.adapters = data;
96
97 return this.adapters;
98 } catch (e) {
99 return this.handleAPIError(e);
100 }
101 }
102
103 private checkDexList(dexs?: string) {
104 if (dexs) {
105 const targetDEXs = dexs.split(',');
106
107 if (!targetDEXs.length) {
108 throw new Error('Invalid DEX list');
109 }
110 }
111 }
112
113 async getRateByRoute(
114 route: AddressOrSymbol[],
115 amount: PriceString,
116 side: SwapSide,
117 options?: RateOptions,
118 srcDecimals?: number,
119 destDecimals?: number,
120 ): Promise<OptimalRatesWithPartnerFees | APIError> {
121 try {
122 const {
123 excludeDEXS,
124 includeDEXS,
125 excludePricingMethods,
126 excludeContractMethods,
127 includeContractMethods,
128 adapterVersion,
129 excludePools,
130 referrer,
131 maxImpact,
132 maxUSDImpact,
133 } = options || {};
134
135 / TODO: all use typed enum for include/excludeDEXS
136 / TODO: check the semver validity for the adapterVersion
137 this.checkDexList(includeDEXS);
138 this.checkDexList(excludeDEXS);
139
140 const _excludePricingMethods = excludePricingMethods
141 ? excludePricingMethods.join(',')
142 : '';
143 const _excludeContractMethods = excludeContractMethods
144 ? excludeContractMethods.join(',')
145 : '';
146 const _includeContractMethods = includeContractMethods
147 ? includeContractMethods.join(',')
148 : '';
149
150 if (route.length < 2) {
151 return { message: 'Invalid Route' };
152 }
153
154 const query = qs.stringify({
155 excludeDEXS,
156 includeDEXS,
157 excludePools,
158 version: adapterVersion,
159 excludePricingMethods: _excludePricingMethods,
160 excludeContractMethods: _excludeContractMethods,
161 includeContractMethods: _includeContractMethods,
162 fromDecimals: srcDecimals,
163 toDecimals: destDecimals,
164 maxImpact,
165 maxUSDImpact,
166 });
Comments to Code: 44 / 2481 = 2 %
Tests to Code: 384 / 2481 = 15 %