If you notice some outdated information please let us know!
PASS
The final review score is indicated as a percentage. The percentage is calculated as Achieved Points due to MAX Possible Points. For each element the answer can be either Yes/No or a percentage. For a detailed breakdown of the individual weights of each question, please consult this document.
Very simply, the audit looks for the following declarations from the developer's site. With these declarations, it is reasonable to trust the smart contracts.
This report is for informational purposes only and does not constitute investment advice of any kind, nor does it constitute an offer to provide investment advisory or other services. Nothing in this report shall be considered a solicitation or offer to buy or sell any security, token, future, option or other financial instrument or to offer or provide any investment advice or service to any person in any jurisdiction. Nothing contained in this report constitutes investment advice or offers any opinion with respect to the suitability of any security, and the views expressed in this report should not be taken as advice to buy, sell or hold any security. The information in this report should not be relied upon for the purpose of investing. In preparing the information contained in this report, we have not taken into account the investment needs, objectives and financial circumstances of any particular investor. This information has no regard to the specific investment objectives, financial situation and particular needs of any specific recipient of this information and investments discussed may not be suitable for all investors.
Any views expressed in this report by us were prepared based upon the information available to us at the time such views were written. The views expressed within this report are limited to DeFiSafety and the author and do not reflect those of any additional or third party and are strictly based upon DeFiSafety, its authors, interpretations and evaluation of relevant data. Changed or additional information could cause such views to change. All information is subject to possible correction. Information may quickly become unreliable for various reasons, including changes in market conditions or economic circumstances.
This completed report is copyright (c) DeFiSafety 2023. Permission is given to copy in whole, retaining this copyright label.
This section looks at the code deployed on the Mainnet that gets reviewed and its corresponding software repository. The document explaining these questions is here.
1. Are the executing code addresses readily available? (%)
They are available at website https://developer.kyber.network/docs/Addresses-Mainnet/, as indicated in the Appendix.
2. Is the code actively being used? (%)
Activity is 200+ transactions a day on contract 0xdd974d5c2e2928dea5f71b9825b8b646686bd200 , as indicated in the Appendix.
3. Is there a public software repository? (Y/N)
GitHub: https://github.com/dynamic-amm
Is there a public software repository with the code at a minimum, but also normally test and scripts. Even if the repository was created just to hold the files and has just 1 transaction, it gets a "Yes". For teams with private repositories, this answer is "No"
4. Is there a development history visible? (%)
With 300 commits and 10 branches, a rich development history is visible.
This metric checks if the software repository demonstrates a strong steady history. This is normally demonstrated by commits, branches and releases in a software repository. A healthy history demonstrates a history of more than a month (at a minimum).
5. Is the team public (not anonymous)? (Y/N)
Location: https://files.kyber.network/DMM-Feb21.pdf
For a "Yes" in this question, the real names of some team members must be public on the website or other documentation (LinkedIn, etc). If the team is anonymous, then this question is a "No".
This section looks at the software documentation. The document explaining these questions is here.
7. Are the basic software functions documented? (Y/N)
The protocol details its functions in an overview page.
8. Does the software function documentation fully (100%) cover the deployed contracts? (%)
Some contracts are covered by documentation, though many contracts deployed are not covered.
9. Are there sufficiently detailed comments for all functions within the deployed contract code (%)
The Comments to Code (CtC) ratio is the primary metric for this score.
10. Is it possible to trace from software documentation to the implementation in code (%)
Code is dissected in the software documentation though the traceability between the two is nonexplicit.
11. Full test suite (Covers all the deployed code) (%)
This score is guided by the Test to Code ratio (TtC). Generally a good test to code ratio is over 100%. However the reviewers best judgement is the final deciding factor.
12. Code coverage (Covers all the deployed lines of code, or explains misses) (%)
There is no indication of code coverage, but a 216% TtC ratio indicates good testing.
13. Scripts and instructions to run the tests? (Y/N)
Scrips/Instructions location: https://github.com/KyberNetwork/smart-contracts
14. Report of the results (%)
There is no test report.
15. Formal Verification test done (%)
No proof of formal verification could be found.
16. Stress Testing environment (%)
Kyber has been deployed to multiple testnets.
This section looks at the 3rd party software audits done. It is explained in this document.
17. Did 3rd Party audits take place? (%)
A single audit has been completed this year; the results are public.
18. Is the bug bounty acceptable high? (%)
Aside from temporary bug bounties offered in 2019 at hackathons, no bug bounty program has been found.
This section covers the documentation of special access controls for a DeFi protocol. The admin access controls are the contracts that allow updating contracts or coefficients in the protocol. Since these contracts can allow the protocol admins to "change the rules", complete disclosure of capabilities is vital for user's transparency. It is explained in this document.
19. Can a user clearly and quickly find the status of the access controls (%)
Access control information is present, but not well labelled.
20. Is the information clear and complete (%)
a) All contracts are clearly labelled as upgradeable (or not) -- 30% -- the contracts are clearly explained as modifiable. b) The type of ownership is clearly indicated (OnlyOwner / MultiSig / Defined Roles) -- 30% --- three different ownership groups are (clearly identified)[https://docs.defisafety.com/master/kyber-network-3.0-0.7-process-quality-review] c) The capabilities for change in the contracts are described -- 30% -- the capacity for change is explained well using both diagrams and text.
21. Is the information in non-technical terms that pertain to the investments (%)
The documentation details the information in technical language.
22. Is there Pause Control documentation including records of tests (%)
Pause controls are mentioned with details, but there is no documented testing.
1contract DMMFactory is IDMMFactory {
2 using EnumerableSet for EnumerableSet.AddressSet;
3
4 uint256 internal constant BPS = 10000;
5
6 address private feeTo;
7 uint16 private governmentFeeBps;
8 address public override feeToSetter;
9
10 mapping(IERC20 => mapping(IERC20 => EnumerableSet.AddressSet)) internal tokenPools;
11 mapping(IERC20 => mapping(IERC20 => address)) public override getUnamplifiedPool;
12 address[] public override allPools;
13
14 event PoolCreated(
15 IERC20 indexed token0,
16 IERC20 indexed token1,
17 address pool,
18 uint32 ampBps,
19 uint256 totalPool
20 );
21 event SetFeeConfiguration(address feeTo, uint16 governmentFeeBps);
22 event SetFeeToSetter(address feeToSetter);
23
24 constructor(address _feeToSetter) public {
25 feeToSetter = _feeToSetter;
26 }
27
28 function createPool(
29 IERC20 tokenA,
30 IERC20 tokenB,
31 uint32 ampBps
32 ) external override returns (address pool) {
33 require(tokenA != tokenB, "DMM: IDENTICAL_ADDRESSES");
34 (IERC20 token0, IERC20 token1) = tokenA < tokenB ? (tokenA, tokenB) : (tokenB, tokenA);
35 require(address(token0) != address(0), "DMM: ZERO_ADDRESS");
36 require(ampBps >= BPS, "DMM: INVALID_BPS");
37 / only exist 1 unamplified pool of a pool.
38 require(
39 ampBps != BPS || getUnamplifiedPool[token0][token1] == address(0),
40 "DMM: UNAMPLIFIED_POOL_EXISTS"
41 );
42 pool = address(new DMMPool());
43 DMMPool(pool).initialize(token0, token1, ampBps);
44 / populate mapping in the reverse direction
45 tokenPools[token0][token1].add(pool);
46 tokenPools[token1][token0].add(pool);
47 if (ampBps == BPS) {
48 getUnamplifiedPool[token0][token1] = pool;
49 getUnamplifiedPool[token1][token0] = pool;
50 }
51 allPools.push(pool);
52
53 emit PoolCreated(token0, token1, pool, ampBps, allPools.length);
54 }
55
56 function setFeeConfiguration(address _feeTo, uint16 _governmentFeeBps) external override {
57 require(msg.sender == feeToSetter, "DMM: FORBIDDEN");
58 require(_governmentFeeBps > 0 && _governmentFeeBps < 2000, "DMM: INVALID FEE");
59 feeTo = _feeTo;
60 governmentFeeBps = _governmentFeeBps;
61
62 emit SetFeeConfiguration(_feeTo, _governmentFeeBps);
63 }
64
65 function setFeeToSetter(address _feeToSetter) external override {
66 require(msg.sender == feeToSetter, "DMM: FORBIDDEN");
67 feeToSetter = _feeToSetter;
68
69 emit SetFeeToSetter(_feeToSetter);
70 }
71
72 function getFeeConfiguration()
73 external
74 override
75 view
76 returns (address _feeTo, uint16 _governmentFeeBps)
77 {
78 _feeTo = feeTo;
79 _governmentFeeBps = governmentFeeBps;
80 }
81
82 function allPoolsLength() external override view returns (uint256) {
83 return allPools.length;
84 }
85
86 function getPools(IERC20 token0, IERC20 token1)
87 external
88 override
89 view
90 returns (address[] memory _tokenPools)
91 {
92 uint256 length = tokenPools[token0][token1].length();
93 _tokenPools = new address[](length);
94 for (uint256 i = 0; i < length; i++) {
95 _tokenPools[i] = tokenPools[token0][token1].at(i);
96 }
97 }
98
99 function getPoolsLength(IERC20 token0, IERC20 token1) external view returns (uint256) {
100 return tokenPools[token0][token1].length();
101 }
102
103 function getPoolAtIndex(
104 IERC20 token0,
105 IERC20 token1,
106 uint256 index
107 ) external view returns (address pool) {
108 return tokenPools[token0][token1].at(index);
109 }
110
111 function isPool(
112 IERC20 token0,
113 IERC20 token1,
114 address pool
115 ) external override view returns (bool) {
116 return tokenPools[token0][token1].contains(pool);
117 }
118}
Comments to Code: 214 / 1807 = 12 %
Tests to Code: 3912 / 1807 = 216 %