logo
bg_imgbg_imgbg_imgbg_img
exclamation mark iconReport an issue

If you notice some outdated information please let us know!

close icon
Name
Email
Your message
arrow-left

Convex

69%

Process Quality Review (0.9)

Convex

Final score:69%
Date:30 Jan 2024
Audit Process:version 0.9
Author:Rex
PQR Score:69%

FAIL

Scoring Appendix

The final review score is indicated as a percentage. The percentage is calculated as Achieved Points due to MAX Possible Points. For each element the answer can be either Yes/No or a percentage. For a detailed breakdown of the individual weights of each question, please consult this document.

The blockchain used by this protocol
Arbitrum
Ethereum
#QuestionAnswer
67%
1.100%
2.Yes
3.0%
4.0%
44%
5.No
6.0%
7.80%
8.40%
9.100%
49%
10.80%
11.30%
12.0%
13.No
84%
14.100%
15.100%
16.60%
17.0%
18.0%
76%
19.100%
20.50%
21.100%
22.60%
23.0%
Total:69%

Very simply, the review looks for the following declarations from the developer's site. With these declarations, it is reasonable to trust the smart contracts.

  • Here are my smart contract on the blockchain(s)
  • Here is the documentation that explains what my smart contracts do
  • Here are the tests I ran to verify my smart contracts
  • Here are all the security steps I took to safeguard these contracts
  • Here is an explanation of the control I have to change these smart contracts
  • Here is how these smart contracts get information from outside the blockchain (if applicable)

This report is for informational purposes only and does not constitute investment advice of any kind, nor does it constitute an offer to provide investment advisory or other services. Nothing in this report shall be considered a solicitation or offer to buy or sell any security, token, future, option or other financial instrument or to offer or provide any investment advice or service to any person in any jurisdiction. Nothing contained in this report constitutes investment advice or offers any opinion with respect to the suitability of any security, and the views expressed in this report should not be taken as advice to buy, sell or hold any security. The information in this report should not be relied upon for the purpose of investing. In preparing the information contained in this report, we have not taken into account the investment needs, objectives and financial circumstances of any particular investor. This information has no regard to the specific investment objectives, financial situation and particular needs of any specific recipient of this information and investments discussed may not be suitable for all investors.

Any views expressed in this report by us were prepared based upon the information available to us at the time such views were written. The views expressed within this report are limited to DeFiSafety and the author and do not reflect those of any additional or third party and are strictly based upon DeFiSafety, its authors, interpretations and evaluation of relevant data. Changed or additional information could cause such views to change. All information is subject to possible correction. Information may quickly become unreliable for various reasons, including changes in market conditions or economic circumstances.

This completed report is copyright (c) DeFiSafety 2023. Permission is given to copy in whole, retaining this copyright label.

Code and Team

67%

This section looks at the code deployed on the relevant chains and team aspects. The document explaining these questions is here.

1. Are the smart contract addresses easy to find? (%)

Answer: 100%

The protocol's smart contract addresses are clearly labelled and easily accessible on the protocol's documentation page under the section titled "Contract Addresses". All the contract addresses that enable the protocol's primary functionalities, such as Booster(main deposit contract), Voter Proxy(whitelist contract), CVX, cvxCRV, CRV Depositor, Reward Factory, Token Factory, Stash Factory, CVX Rewards, cvxCRV Rewards, Pool Manager, and Pool Manager Proxy, are listed with their respective addresses.  

Percentage Score Guidance:
100%
Clearly labelled and on website, documents or repository, quick to find
70%
Clearly labelled and on website, docs or repo but takes a bit of looking
40%
Addresses in mainnet.json, in discord or sub graph, etc
20%
Address found but labeling not clear or easy to find
0%
Executing addresses could not be found

2. Does the protocol have a public software repository? (Y/N)

Answer: Yes

GitHub link is on the home page.

Score Guidance:
Yes
There is a public software repository with the code at a minimum, but also normally test and scripts. Even if the repository was created just to hold the files and has just 1 transaction.
No
For teams with private repositories.

3. Is the team public (not anonymous)?

Answer: 0%

The convex team is anon.

Percentage Score Guidance:
100%
At least two names can be easily found in the protocol's website, documentation or medium. These are then confirmed by the personal websites of the individuals / their linkedin / twitter.
50%
At least one public name can be found to be working on the protocol.
0%
No public team members could be found.

4. How responsive are the devs when we present our initial report?

Answer: 0%

No response from devs for three days.

Percentage Score Guidance:
100%
Devs responded within 24hours
75%
Devs responded within 48 hours
50%
Devs responded within 72 hours
25%
Data not entered yet
0%
no dev response within 72 hours

Code Documentation

44%

This section looks at the software documentation. The document explaining these questions is here.

5. Is there a whitepaper? (Y/N)

Answer: No

No white paper could be found.

Score Guidance:
Yes
There is an actual whitepaper or at least a very detailed doc on the technical basis of the protocol.
No
No whitepaper. Simple gitbook description of the protocol is not sufficient.

6. Is the protocol's software architecture documented? (%)

Answer: 0%

No documentation describing the software architecture of the protocol was found. The documents provided do not contain any clear detailing of the software functions used in contracts or their operations. Also, there are no diagrams showing smart contract interactions or any written explanations of these interactions.  

Percentage Score Guidance:
100%
Detailed software architecture diagram with explanation
75%
Basic block diagram of software aspects
0%
No software architecture documentation

7. Does the software documentation fully cover the deployed contracts' source code? (%)

Answer: 80%

In the Integration Docs section at the bottom of the Gitbook there are function descriptions for the major functions in the Convex protocol. Not all functions are detailed only the top elements. As per guidance this gives a score of 80%.

Percentage Score Guidance:
100%
All contracts and functions documented
80%
Only the major functions documented
79 - 1%
Estimate of the level of software documentation
0%
No software documentation

8. Is it possible to trace the documented software to its implementation in the protocol's source code? (%)

Answer: 40%

Based on the provided information, it can be observed that the documentation does make reference to the corresponding source code on GitHub, however, it does not provide direct traceable links or identifiers. It provides information on audits that have been performed, as well as references to tests made via mainnet forking on their GitHub repository. It points users in the direction of the source code but falls short of providing explicit, traceable connections from requirements to code, tests, and test results.

Percentage Score Guidance:
100%
will be Requirements with traceability to code and to tests (as in avionics DO-178)
90%
on formal requirements with some traceability
80%
for good autogen docs https://developers.morpho.xyz/
60%
Clear association between code and documents via non explicit traceability
40%
Documentation lists all the functions and describes their functions
0%
No connection between documentation and code

9. Is the documentation organized to ensure information availability and clarity? (%)

Answer: 100%

Information is well organized, compartmentalized and easy to navigate

Percentage Score Guidance:
100%
Information is well organized, compartmentalized and easy to navigate
50%
information is decently organized but could use some streamlining
0%
information is generally obfuscated

Testing

49%

This section covers the testing process of the protocol’s smart contract code previous to its deployment on the mainnet. The document explaining these questions is here.

10. Has the protocol tested their deployed code? (%)

Answer: 80%

Test to Code is 11591 / 12398 = 93% which gives a score of 80%

Percentage Score Guidance:
100%
TtC > 120% Both unit and system test visible
80%
TtC > 80% Both unit and system test visible
40%
TtC < 80% Some tests visible
0%
No tests obvious

11. How covered is the protocol's code? (%)

Answer: 30%

There is no evident code coverage report and the level of testing is lower than our preferred. This drives a score of 30%.

Percentage Score Guidance:
100%
Documented full coverage
99 - 51%
Value of test coverage from documented results
50%
No indication of code coverage but clearly there is a complete set of tests
30%
Some tests evident but not complete
0%
No test for coverage seen

12. Is there a detailed report of the protocol's test results?(%)

Answer: 0%

No detail report is evident.

Percentage Score Guidance:
100%
Detailed test report as described below
70%
GitHub code coverage report visible
0%
No test report evident

13. Has the protocol undergone Formal Verification? (Y/N)

Answer: No

No formal verification test report can be seen.

Score Guidance:
Yes
Formal Verification was performed and the report is readily available
No
Formal Verification was not performed and/or the report is not readily available.

Security

84%

This section looks at the 3rd party software audits done. It is explained in this document.

14. Is the protocol sufficiently audited? (%)

Answer: 100%

Convex Finance has undergone multiple audits prior to launch. The audits were performed by MixBytes and PeckShield, both external audit firms. MixBytes performed an audit on the overall platform while PeckShield conducted an audit specifically for the staking contracts related to Frax Finance pools. The audit reports are publicly available, indicating transparency and adherence to best practices in the DeFi space.   One audit found major issues, which were fixed.

Percentage Score Guidance:
100%
Multiple Audits performed before deployment and the audit findings are public and implemented or not required
90%
Single audit performed before deployment and audit findings are public and implemented or not required
70%
Audit(s) performed after deployment and no changes required. The Audit report is public.
65%
Code is forked from an already audited protocol and a changelog is provided explaining why forked code was used and what changes were made. This changelog must justify why the changes made do not affect the audit.
50%
Audit(s) performed after deployment and changes are needed but not implemented.
30%
Audit(s) performed are low-quality and do not indicate proper due diligence.
20%
No audit performed
0%
Audit Performed after deployment, existence is public, report is not public OR smart contract address' not found.
Deduct 25% if the audited code is not available for comparison.

15. Is there a matrix of audit applicability on deployed code (%)? Please refer to the example doc for reference.

Answer: 100%

As there are only two audits, there is no need for a matrix of audit applicability. This allows a 100% score.

Percentage Score Guidance:
100%
Current and clear matrix of applicability
50%
Out of date matrix of applicability
0%
no matrix of applicability

16. Is the bug bounty value acceptably high (%)

Answer: 60%

A self managed bug bounty program with the maximum payout of $250,000. As per our guidance this brings a score of 60%.

Percentage Score Guidance:
100%
Bounty is 10% TVL or at least $1M AND active program (see below)
90%
Bounty is 5% TVL or at least 500k AND active program
80%
Bounty is 5% TVL or at least 500k
70%
Bounty is 100k or over AND active program
60%
Bounty is 100k or over
50%
Bounty is 50k or over AND active program
40%
Bounty is 50k or over
20%
Bug bounty program bounty is less than 50k
0%
No bug bounty program offered / the bug bounty program is dead
An active program means that a third party (such as Immunefi) is actively driving hackers to the site. An inactive program would be static mentions on the docs.

17. Is there documented protocol monitoring (%)?

Answer: 0%

There is no evidence of security protocol monitoring that I could find in the documentation.

Percentage Score Guidance:
100%
Multiple Audits performed before deployment and results public and implemented or not required
80%
Documentation covering protocol specific threat monitoring
60%
Documentation covering generic threat with incident response
40%
Documentation covering operational monitoring with incident response
0%
No on chain monitoring
Add 20% for documented incident response process

18. Is there documented protocol front-end monitoring (%)?

Answer: 0%

The provided documentation does not mention any of the required security measures such as DDOS Protection, DNS steps to protect the domain, Intrusion detection protection on the front end, or Unwanted front-end modification detection. The documentation does mention a bug bounty program and an external security audit, but these do not specifically address front-end monitoring and thus do not fulfill the requirements of this question.  [...]

Percentage Score Guidance:
25%
DDOS Protection
25%
DNS steps to protect the domain
25%
Intrusion detection protection on the front end
25%
Unwanted front-end modification detection

Admin Controls

76%

This section covers the documentation of special access controls for a DeFi protocol. The admin access controls are the contracts that allow updating contracts or coefficients in the protocol. Since these contracts can allow the protocol admins to "change the rules", complete disclosure of capabilities is vital for user's transparency. It is explained in this document.

19. Is the protocol code immutable or upgradeable? (%)

Answer: 100%

The code appears immutable.

Percentage Score Guidance:
100%
Fully Immutable
80%
Updateable with Timelock > 1wk
50%
Updateable code with Roles
30%
Updateable code MultiSig
0%
Updateable code via EOA
Pause control does not impact immutability

20. Is the protocol's code upgradeability clearly explained in non technical terms? (%)

Answer: 50%

50% Code is immutable but this is not mentioned clearly in the documentation  

Percentage Score Guidance:
100%
Code is Immutable and clearly indicated so in documentation OR
100%
Code is upgradeable and clearly explained in non technical terms
50%
Code is upgradeable with minimal explanation
50%
Code is immutable but this is not mentioned clearly in the documentation
0%
No documentation on code upgradeability

21. Are the admin addresses, roles and capabilities clearly explained? (%)

Answer: 100%

100% Admin addresses, roles and capabilities clearly explained In the documentation.  

Percentage Score Guidance:
100%
Admin addresses, roles and capabilities clearly explained OR
100%
If immutable code and no changes possible, no admins required
80%
Admin addresses, roles and capabilities incompletely explained but good content
40%
Admin addresses, roles and capabilities minimally explained, information scattered
0%
No information on admin addresses, roles and capabilities

22. Are the signers of the admin addresses clearly listed and provably distinct humans? (%)

Answer: 60%

60% All signers of the admin addresses are clearly listed. There is no evidence that the signers are provably distinct humans.  

Percentage Score Guidance:
100%
All signers of the admin addresses are clearly listed and provably distinct humans OR
100%
If immutable code and no changes possible, therefore no admins
60%
All signers of the admin addresses are clearly listed
30%
Some signers of the admin addresses are listed
0%
No documentation on the admin addresses

23. Is there a robust documented transaction signing policy? Please refer to the Example doc for reference.(%)

Answer: 0%

There is no evidence of a transaction signing policy.

Percentage Score Guidance:
100%
If immutable and no changes possible
80%
Robust transaction signing process (7 or more elements)
70%
Adequate transaction signing process (5 or more elements)
60%
Weak transaction signing process (3 or more elements)
0%
No transaction signing process evident
Evidence of audits of signers following the process add 20%