If you notice some outdated information please let us know!
Process Quality Review (0.9)
InstaDapp
PASS
Scoring Appendix
The final review score is indicated as a percentage. The percentage is calculated as Achieved Points due to MAX Possible Points. For each element the answer can be either Yes/No or a percentage. For a detailed breakdown of the individual weights of each question, please consult this document.
Very simply, the review looks for the following declarations from the developer's site. With these declarations, it is reasonable to trust the smart contracts.
- Here are my smart contract on the blockchain(s)
- Here is the documentation that explains what my smart contracts do
- Here are the tests I ran to verify my smart contracts
- Here are all the security steps I took to safeguard these contracts
- Here is an explanation of the control I have to change these smart contracts
- Here is how these smart contracts get information from outside the blockchain (if applicable)
This report is for informational purposes only and does not constitute investment advice of any kind, nor does it constitute an offer to provide investment advisory or other services. Nothing in this report shall be considered a solicitation or offer to buy or sell any security, token, future, option or other financial instrument or to offer or provide any investment advice or service to any person in any jurisdiction. Nothing contained in this report constitutes investment advice or offers any opinion with respect to the suitability of any security, and the views expressed in this report should not be taken as advice to buy, sell or hold any security. The information in this report should not be relied upon for the purpose of investing. In preparing the information contained in this report, we have not taken into account the investment needs, objectives and financial circumstances of any particular investor. This information has no regard to the specific investment objectives, financial situation and particular needs of any specific recipient of this information and investments discussed may not be suitable for all investors.
Any views expressed in this report by us were prepared based upon the information available to us at the time such views were written. The views expressed within this report are limited to DeFiSafety and the author and do not reflect those of any additional or third party and are strictly based upon DeFiSafety, its authors, interpretations and evaluation of relevant data. Changed or additional information could cause such views to change. All information is subject to possible correction. Information may quickly become unreliable for various reasons, including changes in market conditions or economic circumstances.
This completed report is copyright (c) DeFiSafety 2023. Permission is given to copy in whole, retaining this copyright label.
Code and Team
92%
This section looks at the code deployed on the relevant chains and team aspects. The document explaining these questions is here.
1. Are the smart contract addresses easy to find? (%)
InstaDapp's smart contracts can be found under the respective platform's tabs in their documentation; Ethereum Mainnet's smart contracts can be found here. A screenshot of a sample of addresses can be found in the appendix.
2. Does the protocol have a public software repository? (Y/N)
InstaDapp's software repo can be found here.
3. Is the team public (not anonymous)?
Team is public. There are more than two contributors in their GitHub who are fully public.
4. How responsive are the devs when we present our initial report?
Awaiting response from devs
Code Documentation
39%
This section looks at the software documentation. The document explaining these questions is here.
5. Is there a whitepaper? (Y/N)
The Overview acts as a whitepaper.
6. Is the protocol's software architecture documented? (%)
The Overview acts as a basic software architecture document.
7. Does the software documentation fully cover the deployed contracts' source code? (%)
We could not find software documentation of the deployed contracts. We did find minimal levels of commenting in some of the documents, not all. For this reason a score of 20% is given.
8. Is it possible to trace the documented software to its implementation in the protocol's source code? (%)
With no documentation, no traceability is possible.
9. Is the documentation organized to ensure information availability and clarity? (%)
Testing
91%
This section covers the testing process of the protocol’s smart contract code previous to its deployment on the mainnet. The document explaining these questions is here.
10. Has the protocol tested their deployed code? (%)
Test to Code exceeds 120% by quite a bit. Score 100% TtC = 9308 / 986 = 944% ─────────────────────────────────────────────────────────────────────────────── Language Files Lines Blanks Comments Code Complexity ─────────────────────────────────────────────────────────────────────────────── JavaScript 12 986 148 218 620 95 ─────────────────────────────────────────────────────────────────────────────── Total 12 986 148 218 620 95 ─────────────────────────────────────────────────────────────────────────────── Estimated Cost to Develop $16,353 Estimated Schedule Effort 2.881274 months Estimated People Required 0.504241 ─────────────────────────────────────────────────────────────────────────────── Processed 33909 bytes, 0.034 megabytes (SI) ─────────────────────────────────────────────────────────────────────────────── ─────────────────────────────────────────────────────────────────────────────── Language Files Lines Blanks Comments Code Complexity ─────────────────────────────────────────────────────────────────────────────── JavaScript 11 1137 173 189 775 65 TypeScript 8 7963 815 112 7036 64 Markdown 1 162 15 0 147 0 YAML 1 46 2 0 44 0 ─────────────────────────────────────────────────────────────────────────────── Total 21 9308 1005 301 8002 129
11. How covered is the protocol's code? (%)
InstaDapp's code coverage is fully documented within their GitHub repository.
12. Is there a detailed report of the protocol's test results?(%)
There is any test report as the readme of the test directory. It indicates code coverage and logic for missing coverage.
13. Has the protocol undergone Formal Verification? (Y/N)
InstaDapp has not undergone formal verification.
Security
78%
This section looks at the 3rd party software audits done. It is explained in this document.
14. Is the protocol sufficiently audited? (%)
While Peckshield's V2 version seems to be the most recent audit available, there are only 1 audit performed before deployment of the current version of InstaDapp. The other audits such as Samczsun's do not provide enough information to confirm subsantial auditing. Because of Peckshield's audits and OpenZeppelin Security, the protocol earns a 90% on this question.
15. Is there a matrix of audit applicability on deployed code (%)? Please refer to the example doc for reference.
Based on the provided sources, there is no indication that the protocol maintains a matrix that outlines the extent of deployed code covered by its conducted audits. The information available pertains to the development environment and use of Instadapp Developer Platform, as well as the networks and functions available. However, there are no references to audits or a matrix of audit applicability. However, with only 3 audits and only 1 applicable to V2, it is not required.
16. Is the bug bounty value acceptably high (%)
A bounty of 250K is active with Immunifi. This gives a score of 70%, as per guidance.
17. Is there documented protocol monitoring (%)?
Upon reviewing the provided documentation from the Instadapp Developer Platform, there is no evidence of documented protocol monitoring. The documentation primarily provides guidance for building applications using their platform and does not include details about monitoring for potential threats or incident responses. Therefore, the score is 0% due to the absence of any on-chain monitoring.
18. Is there documented protocol front-end monitoring (%)?
The documentation of the Instadapp protocol does not mention any measures implemented for front-end monitoring such as DDOS protection, domain protection, intrusion detection, and unwanted modification detection. Therefore, the score for this question is zero.
Admin Controls
54%
This section covers the documentation of special access controls for a DeFi protocol. The admin access controls are the contracts that allow updating contracts or coefficients in the protocol. Since these contracts can allow the protocol admins to "change the rules", complete disclosure of capabilities is vital for user's transparency. It is explained in this document.
19. Is the protocol code immutable or upgradeable? (%)
It appears to be upgradable software with a time lock of two days. As it does not exceed one week we cannot get a score of 80%. However a score of 70% appears valid.
20. Is the protocol's code upgradeability clearly explained in non technical terms? (%)
The protocol is indicated as upgradable in the Introduction of the InstaDApp docs.
21. Are the admin addresses, roles and capabilities clearly explained? (%)
The documentation provides minimal explanation of admin addresses, roles, and capabilities. No documentation elaborates on the capabilities and influence that admins possess within the protocol. There is a lack of comprehensive and transparent detailing of admin addresses, roles, and capabilities.
22. Are the signers of the admin addresses clearly listed and provably distinct humans? (%)
The provided documentation from the Instadapp Developer Platform does not include any information or guidelines about a transaction signing policy. There is no evidence of a policy for securely initiating and verifying transactions, nor any details about the mandatory use of specific wallets, browsers, or VPNs, the storage of backup keys, or any other elements of a robust transaction signing policy.
23. Is there a robust documented transaction signing policy? Please refer to the Example doc for reference.(%)
The provided documentation from the Instadapp Developer Platform does not include any information or guidelines about a transaction signing policy. There is no evidence of a policy for securely initiating and verifying transactions, nor any details about the mandatory use of specific wallets, browsers, or VPNs, the storage of backup keys, or any other elements of a robust transaction signing policy.