If you notice some outdated information please let us know!
PASS
The final review score is indicated as a percentage. The percentage is calculated as Achieved Points due to MAX Possible Points. For each element the answer can be either Yes/No or a percentage. For a detailed breakdown of the individual weights of each question, please consult this document.
Very simply, the audit looks for the following declarations from the developer's site. With these declarations, it is reasonable to trust the smart contracts.
This report is for informational purposes only and does not constitute investment advice of any kind, nor does it constitute an offer to provide investment advisory or other services. Nothing in this report shall be considered a solicitation or offer to buy or sell any security, token, future, option or other financial instrument or to offer or provide any investment advice or service to any person in any jurisdiction. Nothing contained in this report constitutes investment advice or offers any opinion with respect to the suitability of any security, and the views expressed in this report should not be taken as advice to buy, sell or hold any security. The information in this report should not be relied upon for the purpose of investing. In preparing the information contained in this report, we have not taken into account the investment needs, objectives and financial circumstances of any particular investor. This information has no regard to the specific investment objectives, financial situation and particular needs of any specific recipient of this information and investments discussed may not be suitable for all investors.
Any views expressed in this report by us were prepared based upon the information available to us at the time such views were written. The views expressed within this report are limited to DeFiSafety and the author and do not reflect those of any additional or third party and are strictly based upon DeFiSafety, its authors, interpretations and evaluation of relevant data. Changed or additional information could cause such views to change. All information is subject to possible correction. Information may quickly become unreliable for various reasons, including changes in market conditions or economic circumstances.
This completed report is copyright (c) DeFiSafety 2023. Permission is given to copy in whole, retaining this copyright label.
This section looks at the code deployed on the relevant chain that gets reviewed and its corresponding software repository. The document explaining these questions is here.
1. Are the smart contract addresses easy to find? (%)
Gnosis Safe deployments can be found in the README.md of their main GitHub repository. The link then leads to the appropriate deployments.
2. How active is the primary contract? (%)
The main active contract, GnosisSafeProxyFactory.sol (1.3.0), had at least 30 transactions during the last month as indicated in the Appendix.
3. Does the protocol have a public software repository? (Y/N)
Location: https://github.com/gnosis/safe-contracts
4. Is there a development history visible? (%)
With 595 commits and 7 branches, Gnosis Safe demonstrates a healthy software repository.
5. Is the team public (not anonymous)?
Most of the team seems to be public. Although many do not link any social media accounts, they use pictures of themselves. Additionally, we found more than 2 developers with socials and legitimate profile pictures here. Where we found the team is documented in our team appendix at the end of this report.
The difference between this and the old link is solely the link. This section looks at the software documentation. The document explaining these questions is here.
6. Is there a whitepaper? (Y/N)
Location: https://docs.gnosis-safe.io/introduction/the-programmable-account/eoas-vs.-contract-accounts
7. Is the protocol's software architecture documented? (Y/N)
This protocol's software architecture is documented here. However, we would like to see more in-depth documentation on it's architecture, as what is currently displayed is somewhat lackluster.
8. Does the software documentation fully cover the deployed contracts' source code? (%)
Software function documentation only covers signatures and API.
9. Is it possible to trace the documented software to its implementation in the protocol's source code? (%)
There is non-explicit traceability between software documentation and implemented code. The software documentation, however, only covers some of the functions.
10. Has the protocol tested their deployed code? (%)
Code examples are in the Appendix at the end of this report.. As per the SLOC, there is 1068/4192=255% testing to code (TtC). This score is guided by the Test to Code ratio (TtC). Generally a good test to code ratio is over 100%. However, the reviewer's best judgement is the final deciding factor.
11. How covered is the protocol's code? (%)
Gnosis' Safe Contracts Repository has a 99% code coverage.
12. Does the protocol provide scripts and instructions to run their tests? (Y/N)
Scripts/Instructions location: https://github.com/gnosis/safe-contracts#gnosis-safe-contracts
13. Is there a detailed report of the protocol's test results?(%)
Gnosis has an in depth test report here.
14. Has the protocol undergone Formal Verification? (Y/N)
This protocol has undergone formal verification. However, please keep in mind that this was a formal verification of Gnosis Safe V1.0.0, where the verification process was completed on the 27th of February 2019. Gnosis has undergone two version updates since then; 1.2.0 and 1.3.0.
15. Were the smart contracts deployed to a testnet? (Y/N)
This protocol has been deployed to Goerli, Rinkeby, Kovan, Ropsten, and Volta testnets. The addresses can be found under "networkAddresses" in the json files found in this repository.
This section looks at the 3rd party software audits done. It is explained in this document.
16. Is the protocol sufficiently audited? (%)
The latest release and deployment (1.3.0) of Gnosis Safe took place on November 18th 2021. Gnosis Safe 1.3.0 release was audited by G0 Group's Adam Kolář in May 2021, where no issues were found. Previous releases of Gnosis Safe were audited over the last 4 years, adding up to a total of 5 different audits.
17. Is the bounty value acceptably high (%)
The protocol has 3 different immunefi listings; Gnosis, Gnosis Safe, and Gnosis Protocol V2. All of the previous listings have a maximum payout of $54K each, adding up to a total of $162K. This represents ~0.00015% of their $107B TVL. Additionally, Gnosis Chain does have a listing but this will not be counted towards the protocol's bounty. Gnosis Safe additionally has an inactive program, offering a maximum of $1M in payout. Although the active program does not cover up to $1M, the combination of their bug bounty programs will award them a 100%.
This section covers the documentation of special access controls for a DeFi protocol. The admin access controls are the contracts that allow updating contracts or coefficients in the protocol. Since these contracts can allow the protocol admins to "change the rules", complete disclosure of capabilities is vital for user's transparency. It is explained in this document.
18. Is the protocol's admin control information easy to find?
No admin control information could be found. Although Gnosis Safe is very different from DeFi protocols, we feel it is important to still detail that when a new multisig is deployed, no party except the multisig members themselves have control of the contract. Additionally, since change capabilities are not detailed as immutable, admin control information of other contracts are particularly important.
19. Are relevant contracts clearly labelled as upgradeable or immutable? (%)
Mutability of contracts is not detailed.
20. Is the type of smart contract ownership clearly indicated? (%)
Contract ownership is not detailed.
21. Are the protocol's smart contract change capabilities described? (%)
Smart contract change capabilities are not identified in.
22. Is the protocol's admin control information easy to understand? (%)
Admin control information could not be located.
23. Is there sufficient Pause Control documentation? (%)
Pause control is not applicable to this protocol.
24. Is there sufficient Timelock documentation? (%)
Timelock information is not specified.
25. Is the Timelock of an adequate length? (Y/N)
Timelock remains unspecified.
This section goes over the documentation that a protocol may or may not supply about their Oracle usage. Oracles are a fundamental part of DeFi as they are responsible for relaying tons of price data information to thousands of protocols using blockchain technology. Not only are they important for price feeds, but they are also an essential component of transaction verification and security. This is explained in this document.
26. Is the protocol's Oracle sufficiently documented? (%)
This protocol does not use oracles.
27. Is front running mitigated by this protocol? (Y/N)
Front running cannot be applied to this protocol as it does not use an oracle.
28. Can flashloan attacks be applied to the protocol, and if so, are those flashloan attack risks mitigated? (Y/N)
Flashloan attacks cannot be applied to this protocol.
1// SPDX-License-Identifier: LGPL-3.0-only
2pragma solidity >=0.7.0 <0.9.0;
3
4import "./GnosisSafeProxy.sol";
5import "./IProxyCreationCallback.sol";
6
7/// @title Proxy Factory - Allows to create new proxy contact and execute a message call to the new proxy within one transaction.
8/// @author Stefan George - <stefan@gnosis.pm>
9contract GnosisSafeProxyFactory {
10 event ProxyCreation(GnosisSafeProxy proxy, address singleton);
11
12 /// @dev Allows to create new proxy contact and execute a message call to the new proxy within one transaction.
13 /// @param singleton Address of singleton contract.
14 /// @param data Payload for message call sent to new proxy contract.
15 function createProxy(address singleton, bytes memory data) public returns (GnosisSafeProxy proxy) {
16 proxy = new GnosisSafeProxy(singleton);
17 if (data.length > 0)
18 // solhint-disable-next-line no-inline-assembly
19 assembly {
20 if eq(call(gas(), proxy, 0, add(data, 0x20), mload(data), 0, 0), 0) {
21 revert(0, 0)
22 }
23 }
24 emit ProxyCreation(proxy, singleton);
25 }
26
27 /// @dev Allows to retrieve the runtime code of a deployed Proxy. This can be used to check that the expected Proxy was deployed.
28 function proxyRuntimeCode() public pure returns (bytes memory) {
29 return type(GnosisSafeProxy).runtimeCode;
30 }
31
32 /// @dev Allows to retrieve the creation code used for the Proxy deployment. With this it is easily possible to calculate predicted address.
33 function proxyCreationCode() public pure returns (bytes memory) {
34 return type(GnosisSafeProxy).creationCode;
35 }
36
37 /// @dev Allows to create new proxy contact using CREATE2 but it doesn't run the initializer.
38 /// This method is only meant as an utility to be called from other methods
39 /// @param _singleton Address of singleton contract.
40 /// @param initializer Payload for message call sent to new proxy contract.
41 /// @param saltNonce Nonce that will be used to generate the salt to calculate the address of the new proxy contract.
42 function deployProxyWithNonce(
43 address _singleton,
44 bytes memory initializer,
45 uint256 saltNonce
46 ) internal returns (GnosisSafeProxy proxy) {
47 // If the initializer changes the proxy address should change too. Hashing the initializer data is cheaper than just concatinating it
48 bytes32 salt = keccak256(abi.encodePacked(keccak256(initializer), saltNonce));
49 bytes memory deploymentData = abi.encodePacked(type(GnosisSafeProxy).creationCode, uint256(uint160(_singleton)));
50 // solhint-disable-next-line no-inline-assembly
51 assembly {
52 proxy := create2(0x0, add(0x20, deploymentData), mload(deploymentData), salt)
53 }
54 require(address(proxy) != address(0), "Create2 call failed");
55 }
56
57 /// @dev Allows to create new proxy contact and execute a message call to the new proxy within one transaction.
58 /// @param _singleton Address of singleton contract.
59 /// @param initializer Payload for message call sent to new proxy contract.
60 /// @param saltNonce Nonce that will be used to generate the salt to calculate the address of the new proxy contract.
61 function createProxyWithNonce(
62 address _singleton,
63 bytes memory initializer,
64 uint256 saltNonce
65 ) public returns (GnosisSafeProxy proxy) {
66 proxy = deployProxyWithNonce(_singleton, initializer, saltNonce);
67 if (initializer.length > 0)
68 // solhint-disable-next-line no-inline-assembly
69 assembly {
70 if eq(call(gas(), proxy, 0, add(initializer, 0x20), mload(initializer), 0, 0), 0) {
71 revert(0, 0)
72 }
73 }
74 emit ProxyCreation(proxy, _singleton);
75 }
76
77 /// @dev Allows to create new proxy contact, execute a message call to the new proxy and call a specified callback within one transaction
78 /// @param _singleton Address of singleton contract.
79 /// @param initializer Payload for message call sent to new proxy contract.
80 /// @param saltNonce Nonce that will be used to generate the salt to calculate the address of the new proxy contract.
81 /// @param callback Callback that will be invoced after the new proxy contract has been successfully deployed and initialized.
82 function createProxyWithCallback(
83 address _singleton,
84 bytes memory initializer,
85 uint256 saltNonce,
86 IProxyCreationCallback callback
87 ) public returns (GnosisSafeProxy proxy) {
88 uint256 saltNonceWithCallback = uint256(keccak256(abi.encodePacked(saltNonce, callback)));
89 proxy = createProxyWithNonce(_singleton, initializer, saltNonceWithCallback);
90 if (address(callback) != address(0)) callback.proxyCreated(proxy, _singleton, initializer, saltNonce);
91 }
92
93 /// @dev Allows to get the address for a new proxy contact created via `createProxyWithNonce`
94 /// This method is only meant for address calculation purpose when you use an initializer that would revert,
95 /// therefore the response is returned with a revert. When calling this method set `from` to the address of the proxy factory.
96 /// @param _singleton Address of singleton contract.
97 /// @param initializer Payload for message call sent to new proxy contract.
98 /// @param saltNonce Nonce that will be used to generate the salt to calculate the address of the new proxy contract.
99 function calculateCreateProxyWithNonceAddress(
100 address _singleton,
101 bytes calldata initializer,
102 uint256 saltNonce
103 ) external returns (GnosisSafeProxy proxy) {
104 proxy = deployProxyWithNonce(_singleton, initializer, saltNonce);
105 revert(string(abi.encodePacked(proxy)));
106 }
107}