If you notice some outdated information please let us know!
PASS
The final review score is indicated as a percentage. The percentage is calculated as Achieved Points due to MAX Possible Points. For each element the answer can be either Yes/No or a percentage. For a detailed breakdown of the individual weights of each question, please consult this document.
Very simply, the audit looks for the following declarations from the developer's site. With these declarations, it is reasonable to trust the smart contracts.
This report is for informational purposes only and does not constitute investment advice of any kind, nor does it constitute an offer to provide investment advisory or other services. Nothing in this report shall be considered a solicitation or offer to buy or sell any security, token, future, option or other financial instrument or to offer or provide any investment advice or service to any person in any jurisdiction. Nothing contained in this report constitutes investment advice or offers any opinion with respect to the suitability of any security, and the views expressed in this report should not be taken as advice to buy, sell or hold any security. The information in this report should not be relied upon for the purpose of investing. In preparing the information contained in this report, we have not taken into account the investment needs, objectives and financial circumstances of any particular investor. This information has no regard to the specific investment objectives, financial situation and particular needs of any specific recipient of this information and investments discussed may not be suitable for all investors.
Any views expressed in this report by us were prepared based upon the information available to us at the time such views were written. The views expressed within this report are limited to DeFiSafety and the author and do not reflect those of any additional or third party and are strictly based upon DeFiSafety, its authors, interpretations and evaluation of relevant data. Changed or additional information could cause such views to change. All information is subject to possible correction. Information may quickly become unreliable for various reasons, including changes in market conditions or economic circumstances.
This completed report is copyright (c) DeFiSafety 2023. Permission is given to copy in whole, retaining this copyright label.
This section looks at the code deployed on the Mainnet that gets reviewed and its corresponding software repository. The document explaining these questions is here.
1. Are the executing code addresses readily available? (%)
They are available at website in the README.md of the Delphi GitHub repository at https://github.com/akropolisio/delphi, as indicated in the Appendix.
2. Is the code actively being used? (%)
Activity is over 10 transactions a day, including internal, on contract AdminUpgradeabilityProxy.sol (Staking Contract), as indicated in the Appendix.
3. Is there a public software repository? (Y/N)
GitHub: https://github.com/akropolisio
Is there a public software repository with the code at a minimum, but also normally test and scripts. Even if the repository was created just to hold the files and has just 1 transaction, it gets a "Yes". For teams with private repositories, this answer is "No"
4. Is there a development history visible? (%)
This protocol has a rich development history, with some 515 commits and 68 separate branches.
This metric checks if the software repository demonstrates a strong steady history. This is normally demonstrated by commits, branches and releases in a software repository. A healthy history demonstrates a history of more than a month (at a minimum).
5. Is the team public (not anonymous)? (Y/N)
For a "Yes" in this question, the real names of some team members must be public on the website or other documentation (LinkedIn, etc). If the team is anonymous, then this question is a "No".
This section looks at the software documentation. The document explaining these questions is here.
6. Is there a whitepaper? (Y/N)
7. Are the basic software functions documented? (Y/N)
This whitepaper details the basic software functions.
8. Does the software function documentation fully (100%) cover the deployed contracts? (%)
The software documentation is impressive and covers all deployed contracts.
9. Are there sufficiently detailed comments for all functions within the deployed contract code (%)
The Comments to Code (CtC) ratio is the primary metric for this score.
10. Is it possible to trace from software documentation to the implementation in code (%)
Akropolis' code is clearly outlined in the docs and can be non explicitly traced in their github repository for each of their individual projects.
11. Full test suite (Covers all the deployed code) (%)
This score is guided by the Test to Code ratio (TtC). Generally a good test to code ratio is over 100%. However the reviewers best judgement is the final deciding factor.
12. Code coverage (Covers all the deployed lines of code, or explains misses) (%)
Documented code coverage could not be found, but there is clear evidence of robust testing in the TtC score.
13. Scripts and instructions to run the tests? (Y/N)
Scrips/Instructions location: https://github.com/akropolisio/delphi/tree/release-1.0/scripts.
14. Report of the results (%)
No test report was found.
15. Formal Verification test done (%)
No formal verification was found.
16. Stress Testing environment (%)
Akropolis has been deployed in full on the Rinkeby testnet.
This section looks at the 3rd party software audits done. It is explained in this document.
17. Did 3rd Party audits take place? (%)
Certik published two Akropolis Sparta audit reports before the mainnet launch. MixBytes published a Delphi staking audit report after mainnnet launch. MythX did too.
18. Is the bug bounty acceptable high? (%)
The bounty program offered by Akropolis has a maximum reward of $40,000.
This section covers the documentation of special access controls for a DeFi protocol. The admin access controls are the contracts that allow updating contracts or coefficients in the protocol. Since these contracts can allow the protocol admins to "change the rules", complete disclosure of capabilities is vital for user's transparency. It is explained in this document.
19. Can a user clearly and quickly find the status of the access controls (%)
Governance information was found at https://wiki.akropolis.io/sparta/#akro-governance, however there are no details explicitly detailing what the admins have control over.
20. Is the information clear and complete (%)
21. Is the information in non-technical terms that pertain to the investments (%)
Governance information is written in a technical way that does not communicate to users about how/why their funds are safe.
22. Is there Pause Control documentation including records of tests (%)
There is no pause control documentation.
1pragma solidity ^0.5.12;
2
3import "../common/Base.sol";
4import "../interfaces/core/CoreInterface.sol";
5import "../utils/AddressMap.sol";
6
7contract Pool is Base, CoreInterface {
8
9 /* Short description */
10 string public name;
11 string public description;
12 address public founder;
13
14 /* Modules map */
15 AddressMap.Data modules;
16
17 using AddressList for AddressList.Data;
18 using AddressMap for AddressMap.Data;
19
20 /* Module constant mapping */
21 mapping(bytes32 => bool) public is_constant;
22
23 /**
24 * @dev Contract ABI storage
25 * the contract interface contains source URI
26 */
27 mapping(address => string) public abiOf;
28
29 function initialize() public initializer {
30 Base.initialize();
31 founder = _msgSender();
32 }
33
34 function setMetadata(string memory _name, string memory _description) public onlyOwner {
35 name = _name;
36 description = _description;
37 }
38
39 /**
40 * @dev Set new module for given name
41 * @param _name infrastructure node name
42 * @param _module infrastructure node address
43 * @param _constant have a `true` value when you create permanent name of module
44 */
45 function set(string memory _name, address _module, bool _constant) public onlyOwner {
46
47 require(!isConstant(_name), "Pool: module address can not be replaced");
48
49 // Notify
50 if (modules.get(_name) != ZERO_ADDRESS)
51 emit ModuleReplaced(_name, modules.get(_name), _module);
52 else
53 emit ModuleAdded(_name, _module);
54
55 // Set module in the map
56 modules.set(_name, _module);
57
58 // Register constant flag
59 is_constant[keccak256(abi.encodePacked(_name))] = _constant;
60 }
61
62 /**
63 * @dev Remove module by name
64 * @param _name module name
65 */
66 function remove(string memory _name) public onlyOwner {
67 require(!isConstant(_name), "Pool: module can not be removed");
68
69 // Notify
70 emit ModuleRemoved(_name, modules.get(_name));
71
72 // Remove module
73 modules.remove(_name);
74 }
75
76 /**
77 * @dev Fast module exist check
78 * @param _module is a module address
79 * @return `true` wnen core contains module
80 */
81 function contains(address _module) public view returns (bool)
82 {
83 return modules.items.contains(_module);
84 }
85
86 /**
87 * @dev Modules counter
88 * @return count of modules in core
89 */
90 function size() public view returns (uint)
91 {
92 return modules.size();
93 }
94
95 /**
96 * @dev Check for module have permanent name
97 * @param _name is a module name
98 * @return `true` when module have permanent name
99 */
100 function isConstant(string memory _name) public view returns (bool)
101 {
102 return is_constant[keccak256(abi.encodePacked(_name))];
103 }
104
105 /**
106 * @dev Get module by name
107 * @param _name is module name
108 * @return module address
109 */
110 function get(string memory _name) public view returns (address)
111 {
112 return modules.get(_name);
113 }
114
115 /*
116 * @dev Get module name by address
117 * @param _module is a module address
118 * @return module name
119 */
120 function getName(address _module) public view returns (string memory)
121 {
122 return modules.keyOf[_module];
123 }
124
125 /*
126 * @dev Get first module
127 * @return first address
128 */
129 function first() public view returns (address)
130 {
131 return modules.items.head;
132 }
133
134 /**
135 * @dev Get next module
136 * @param _current is an current address
137 * @return next address
138 */
139 function next(address _current) public view returns (address)
140 {
141 return modules.items.next(_current);
142 }
143
144}
Comments to Code: 846 / 1441 = 59 %
Tests to Code: 1347 / 1441 = 93 %