If you notice some outdated information please let us know!
FAIL
The final review score is indicated as a percentage. The percentage is calculated as Achieved Points due to MAX Possible Points. For each element the answer can be either Yes/No or a percentage. For a detailed breakdown of the individual weights of each question, please consult this document.
Very simply, the audit looks for the following declarations from the developer's site. With these declarations, it is reasonable to trust the smart contracts.
This report is for informational purposes only and does not constitute investment advice of any kind, nor does it constitute an offer to provide investment advisory or other services. Nothing in this report shall be considered a solicitation or offer to buy or sell any security, token, future, option or other financial instrument or to offer or provide any investment advice or service to any person in any jurisdiction. Nothing contained in this report constitutes investment advice or offers any opinion with respect to the suitability of any security, and the views expressed in this report should not be taken as advice to buy, sell or hold any security. The information in this report should not be relied upon for the purpose of investing. In preparing the information contained in this report, we have not taken into account the investment needs, objectives and financial circumstances of any particular investor. This information has no regard to the specific investment objectives, financial situation and particular needs of any specific recipient of this information and investments discussed may not be suitable for all investors.
Any views expressed in this report by us were prepared based upon the information available to us at the time such views were written. The views expressed within this report are limited to DeFiSafety and the author and do not reflect those of any additional or third party and are strictly based upon DeFiSafety, its authors, interpretations and evaluation of relevant data. Changed or additional information could cause such views to change. All information is subject to possible correction. Information may quickly become unreliable for various reasons, including changes in market conditions or economic circumstances.
This completed report is copyright (c) DeFiSafety 2023. Permission is given to copy in whole, retaining this copyright label.
This section looks at the code deployed on the Mainnet that gets reviewed and its corresponding software repository. The document explaining these questions is here.
1. Are the executing code addresses readily available? (%)
They are available at website https://dodoex.github.io/docs/docs/deployedInfo, as indicated in the Appendix.
2. Is the code actively being used? (%)
Activity is 50 transactions a day on contract DODO Approve Proxy, as indicated in the Appendix.
3. Is there a public software repository? (Y/N)
GitHub: https://github.com/DODOEX
Is there a public software repository with the code at a minimum, but also normally test and scripts. Even if the repository was created just to hold the files and has just 1 transaction, it gets a "Yes". For teams with private repositories, this answer is "No"
4. Is there a development history visible? (%)
At 731 commits and 12 branches, it's clear this development history won't be going the way of the Dodo anytime soon.
This metric checks if the software repository demonstrates a strong steady history. This is normally demonstrated by commits, branches and releases in a software repository. A healthy history demonstrates a history of more than a month (at a minimum).
5. Is the team public (not anonymous)? (Y/N)
Location: https://twitter.com/Diane_0320?ref_src=twsrc%5Egoogle%7Ctwcamp%5Eserp%7Ctwgr%5Eauthor Note: finding other DODO team members has proven exceptionally difficult.
For a "Yes" in this question, the real names of some team members must be public on the website or other documentation (LinkedIn, etc). If the team is anonymous, then this question is a "No".
This section looks at the software documentation. The document explaining these questions is here.
7. Are the basic software functions documented? (Y/N)
The docs contain some basic software functions.
8. Does the software function documentation fully (100%) cover the deployed contracts? (%)
Some of the major contracts, as well as API, are covered. However, there are a decent number of contracts that are not covered by documentation.
9. Are there sufficiently detailed comments for all functions within the deployed contract code (%)
The Comments to Code (CtC) ratio is the primary metric for this score.
10. Is it possible to trace from software documentation to the implementation in code (%)
Given that not all contracts deployed are covered by the documentation, it is impossible to determine traceability or even association between documents and the DODO source code.
11. Full test suite (Covers all the deployed code) (%)
This score is guided by the Test to Code ratio (TtC). Generally a good test to code ratio is over 100%. However the reviewers best judgement is the final deciding factor.
12. Code coverage (Covers all the deployed lines of code, or explains misses) (%)
No code coverage test was found, but there is evidence of fairly complete testing.
13. Scripts and instructions to run the tests? (Y/N)
14. Report of the results (%)
No test report was found.
15. Formal Verification test done (%)
The exchange has had "formal verification testing methods" undertaken on it by Beosin, one of the "audits". It is unclear what this means as there is insufficient elaboration. See Compound's formal verification as an example.
16. Stress Testing environment (%)
DODO has been deployed in full on the Rinkeby testnet.
This section looks at the 3rd party software audits done. It is explained in this document.
17. Did 3rd Party audits take place? (%)
Multiple audits have taken place on Dodo, but not before the code was deployed. Changes were implemented.
18. Is the bug bounty acceptable high? (%)
DODO's Bug Bounty program rewards participating users with up to 200k for the most critical of finds.
This section covers the documentation of special access controls for a DeFi protocol. The admin access controls are the contracts that allow updating contracts or coefficients in the protocol. Since these contracts can allow the protocol admins to "change the rules", complete disclosure of capabilities is vital for user's transparency. It is explained in this document.
19. Can a user clearly and quickly find the status of the access controls (%)
Access control documentation could not be found. Although there is some access control information for LPs and market traders on DODO, there is no information how much control the admins have over the protocol.
20. Is the information clear and complete (%)
a) All contracts are clearly labelled as upgradeable (or not) -- 5% -- no contracts are labelled with regards to upgradeability. The Admin DAO is expected to be in full control of the exchange when it is created. b) The type of ownership is clearly indicated (OnlyOwner / MultiSig / Defined Roles) -- 5% -- a DAO is on DODO's roadmap, but there is no mention on how this is progressing. This implies full ownership on behalf of the developers, but this is unconfirmed. c) The capabilities for change in the contracts are described -- 0% -- no capabilities are described.
21. Is the information in non-technical terms that pertain to the investments (%)
There is no access control information that relates to users' investments' safety in the DODO documentation.
22. Is there Pause Control documentation including records of tests (%)
No pause control was documented.
1 address constant _ETH_ADDRESS_ = 0xEeeeeEeeeEeEeeEeEeEeeEEEeeeeEeeeeeeeEEeE;
2 address public immutable _WETH_;
3 address public immutable _DODO_APPROVE_PROXY_;
4 address public immutable _DODO_SELL_HELPER_;
5 address public immutable _DVM_FACTORY_;
6 address public immutable _DPP_FACTORY_;
7 mapping (address => bool) public isWhiteListed;
8
9 // ============ Events ============
10
11 event OrderHistory(
12 address fromToken,
13 address toToken,
14 address sender,
15 uint256 fromAmount,
16 uint256 returnAmount
17 );
18
19 // ============ Modifiers ============
20
21 modifier judgeExpired(uint256 deadLine) {
22 require(deadLine >= block.timestamp, "DODOV2Proxy02: EXPIRED");
23 _;
24 }
25
26 fallback() external payable {}
27
28 receive() external payable {}
29
30 constructor(
31 address dvmFactory,
32 address dppFactory,
33 address payable weth,
34 address dodoApproveProxy,
35 address dodoSellHelper
36 ) public {
37 _DVM_FACTORY_ = dvmFactory;
38 _DPP_FACTORY_ = dppFactory;
39 _WETH_ = weth;
40 _DODO_APPROVE_PROXY_ = dodoApproveProxy;
41 _DODO_SELL_HELPER_ = dodoSellHelper;
42 }
43
44 function addWhiteList (address contractAddr) public onlyOwner {
45 isWhiteListed[contractAddr] = true;
46 }
47
48 function removeWhiteList (address contractAddr) public onlyOwner {
49 isWhiteListed[contractAddr] = false;
50 }
51
52 // ============ DVM Functions (create & add liquidity) ============
53
54 function createDODOVendingMachine(
55 address baseToken,
56 address quoteToken,
57 uint256 baseInAmount,
58 uint256 quoteInAmount,
59 uint256 lpFeeRate,
60 uint256 i,
61 uint256 k,
62 bool isOpenTWAP,
63 uint256 deadLine
64 )
65 external
66 override
67 payable
68 preventReentrant
69 judgeExpired(deadLine)
70 returns (address newVendingMachine, uint256 shares)
71 {
72 {
73 address _baseToken = baseToken == _ETH_ADDRESS_ ? _WETH_ : baseToken;
74 address _quoteToken = quoteToken == _ETH_ADDRESS_ ? _WETH_ : quoteToken;
75 newVendingMachine = IDODOV2(_DVM_FACTORY_).createDODOVendingMachine(
76 _baseToken,
77 _quoteToken,
78 lpFeeRate,
79 i,
80 k,
81 isOpenTWAP
82 );
83 }
84
85 {
86 address _baseToken = baseToken;
87 address _quoteToken = quoteToken;
88 _deposit(
89 msg.sender,
90 newVendingMachine,
91 _baseToken,
92 baseInAmount,
93 _baseToken == _ETH_ADDRESS_
94 );
95 _deposit(
96 msg.sender,
97 newVendingMachine,
98 _quoteToken,
99 quoteInAmount,
100 _quoteToken == _ETH_ADDRESS_
101 );
102 }
103
104 (shares, , ) = IDODOV2(newVendingMachine).buyShares(msg.sender);
105 }
106
107 function addDVMLiquidity(
108 address dvmAddress,
109 uint256 baseInAmount,
110 uint256 quoteInAmount,
111 uint256 baseMinAmount,
112 uint256 quoteMinAmount,
113 uint8 flag, // 0 - ERC20, 1 - baseInETH, 2 - quoteInETH
114 uint256 deadLine
115 )
116 external
117 override
118 payable
119 preventReentrant
120 judgeExpired(deadLine)
121 returns (
122 uint256 shares,
123 uint256 baseAdjustedInAmount,
124 uint256 quoteAdjustedInAmount
125 )
126 {
127 address _dvm = dvmAddress;
128 (baseAdjustedInAmount, quoteAdjustedInAmount) = _addDVMLiquidity(
129 _dvm,
130 baseInAmount,
131 quoteInAmount
132 );
133 require(
134 baseAdjustedInAmount >= baseMinAmount && quoteAdjustedInAmount >= quoteMinAmount,
135 "DODOV2Proxy02: deposit amount is not enough"
136 );
137
138 _deposit(msg.sender, _dvm, IDODOV2(_dvm)._BASE_TOKEN_(), baseAdjustedInAmount, flag == 1);
139 _deposit(msg.sender, _dvm, IDODOV2(_dvm)._QUOTE_TOKEN_(), quoteAdjustedInAmount, flag == 2);
140
141 (shares, , ) = IDODOV2(_dvm).buyShares(msg.sender);
142 // refund dust eth
143 if (flag == 1 && msg.value > baseAdjustedInAmount) msg.sender.transfer(msg.value - baseAdjustedInAmount);
144 if (flag == 2 && msg.value > quoteAdjustedInAmount) msg.sender.transfer(msg.value - quoteAdjustedInAmount);
145 }
146
147 function _addDVMLiquidity(
148 address dvmAddress,
149 uint256 baseInAmount,
150 uint256 quoteInAmount
151 ) internal view returns (uint256 baseAdjustedInAmount, uint256 quoteAdjustedInAmount) {
152 (uint256 baseReserve, uint256 quoteReserve) = IDODOV2(dvmAddress).getVaultReserve();
153 if (quoteReserve == 0 && baseReserve == 0) {
154 baseAdjustedInAmount = baseInAmount;
155 quoteAdjustedInAmount = quoteInAmount;
156 }
157 if (quoteReserve == 0 && baseReserve > 0) {
158 baseAdjustedInAmount = baseInAmount;
159 quoteAdjustedInAmount = 0;
160 }
161 if (quoteReserve > 0 && baseReserve > 0) {
162 uint256 baseIncreaseRatio = DecimalMath.divFloor(baseInAmount, baseReserve);
163 uint256 quoteIncreaseRatio = DecimalMath.divFloor(quoteInAmount, quoteReserve);
164 if (baseIncreaseRatio <= quoteIncreaseRatio) {
165 baseAdjustedInAmount = baseInAmount;
166 quoteAdjustedInAmount = DecimalMath.mulFloor(quoteReserve, baseIncreaseRatio);
167 } else {
168 quoteAdjustedInAmount = quoteInAmount;
169 baseAdjustedInAmount = DecimalMath.mulFloor(baseReserve, quoteIncreaseRatio);
170 }
171 }
172 }
173
174 // =========== DPP Functions (create & reset) ===========
175
176 function createDODOPrivatePool(
177 address baseToken,
178 address quoteToken,
179 uint256 baseInAmount,
180 uint256 quoteInAmount,
181 uint256 lpFeeRate,
182 uint256 i,
183 uint256 k,
184 bool isOpenTwap,
185 uint256 deadLine
186 )
187 external
188 override
189 payable
190 preventReentrant
191 judgeExpired(deadLine)
192 returns (address newPrivatePool)
193 {
194 newPrivatePool = IDODOV2(_DPP_FACTORY_).createDODOPrivatePool();
195
196 address _baseToken = baseToken;
197 address _quoteToken = quoteToken;
198 _deposit(msg.sender, newPrivatePool, _baseToken, baseInAmount, _baseToken == _ETH_ADDRESS_);
199 _deposit(
200 msg.sender,
201 newPrivatePool,
202 _quoteToken,
203 quoteInAmount,
204 _quoteToken == _ETH_ADDRESS_
205 );
206
207 if (_baseToken == _ETH_ADDRESS_) _baseToken = _WETH_;
208 if (_quoteToken == _ETH_ADDRESS_) _quoteToken = _WETH_;
209
210 IDODOV2(_DPP_FACTORY_).initDODOPrivatePool(
211 newPrivatePool,
212 msg.sender,
213 _baseToken,
214 _quoteToken,
215 lpFeeRate,
216 k,
217 i,
218 isOpenTwap
219 );
220 }
221
Comments to Code: 1057 / 5725 = 18 %
Tests to Code: 6457 / 5725 = 113 %