If you notice some outdated information please let us know!
FAIL
The final review score is indicated as a percentage. The percentage is calculated as Achieved Points due to MAX Possible Points. For each element the answer can be either Yes/No or a percentage. For a detailed breakdown of the individual weights of each question, please consult this document.
Very simply, the audit looks for the following declarations from the developer's site. With these declarations, it is reasonable to trust the smart contracts.
This report is for informational purposes only and does not constitute investment advice of any kind, nor does it constitute an offer to provide investment advisory or other services. Nothing in this report shall be considered a solicitation or offer to buy or sell any security, token, future, option or other financial instrument or to offer or provide any investment advice or service to any person in any jurisdiction. Nothing contained in this report constitutes investment advice or offers any opinion with respect to the suitability of any security, and the views expressed in this report should not be taken as advice to buy, sell or hold any security. The information in this report should not be relied upon for the purpose of investing. In preparing the information contained in this report, we have not taken into account the investment needs, objectives and financial circumstances of any particular investor. This information has no regard to the specific investment objectives, financial situation and particular needs of any specific recipient of this information and investments discussed may not be suitable for all investors.
Any views expressed in this report by us were prepared based upon the information available to us at the time such views were written. The views expressed within this report are limited to DeFiSafety and the author and do not reflect those of any additional or third party and are strictly based upon DeFiSafety, its authors, interpretations and evaluation of relevant data. Changed or additional information could cause such views to change. All information is subject to possible correction. Information may quickly become unreliable for various reasons, including changes in market conditions or economic circumstances.
This completed report is copyright (c) DeFiSafety 2023. Permission is given to copy in whole, retaining this copyright label.
This section looks at the code deployed on the Mainnet that gets reviewed and its corresponding software repository. The document explaining these questions is here.
1. Are the executing code addresses readily available? (%)
They are available at website https://harvest-finance.gitbook.io/harvest-finance/how-it-works/contract-addresses-1, as indicated in the Appendix.
2. Is the code actively being used? (%)
Activity is more than 10 transactions a day on contract RewardToken, as indicated in the Appendix.
3. Is there a public software repository? (Y/N)
GitHub: https://github.com/harvest-finance
Is there a public software repository with the code at a minimum, but also normally test and scripts. Even if the repository was created just to hold the files and has just 1 transaction, it gets a "Yes". For teams with private repositories, this answer is "No"
4. Is there a development history visible? (%)
With one branch and 47 commits, Harvest Finance's contract repository has a development history a few weeks short of a ripe fall harvest.
This metric checks if the software repository demonstrates a strong steady history. This is normally demonstrated by commits, branches and releases in a software repository. A healthy history demonstrates a history of more than a month (at a minimum).
5. Is the team public (not anonymous)? (Y/N)
The harvest finance team remains anonymous.
For a "Yes" in this question, the real names of some team members must be public on the website or other documentation (LinkedIn, etc). If the team is anonymous, then this question is a "No".
This section looks at the software documentation. The document explaining these questions is here.
6. Is there a whitepaper? (Y/N)
7. Are the basic software functions documented? (Y/N)
Neither the docs nor the repository document basic software functions.
8. Does the software function documentation fully (100%) cover the deployed contracts? (%)
A detailed protocol architecture diagram clearly defines how the protocols interact with each other and API responses assist the documentation, but more explanation in language of all contracts is needed.
9. Are there sufficiently detailed comments for all functions within the deployed contract code (%)
The Comments to Code (CtC) ratio is the primary metric for this score.
10. Is it possible to trace from software documentation to the implementation in code (%)
As there are no smart contract software functions documented in the Harvest Finance documentation, it is impossible for us to evaluate their traceability towards the implementation in the protocol's source code.
11. Full test suite (Covers all the deployed code) (%)
This score is guided by the Test to Code ratio (TtC). Generally a good test to code ratio is over 100%. However the reviewers best judgement is the final deciding factor.
12. Code coverage (Covers all the deployed lines of code, or explains misses) (%)
No code coverage test was found, but a healthy test to code ratio indicates significant testing.
13. Scripts and instructions to run the tests? (Y/N)
Scripts/Instructions location: https://github.com/harvest-finance/harvest-strategy-bsc#run
14. Report of the results (%)
The test report can be found at https://github.com/harvest-finance/harvest-strategy-bsc#run.
15. Formal Verification test done (%)
No formal verification has been conducted.
16. Stress Testing environment (%)
No mention of deployment to a testnet was found.
This section looks at the 3rd party software audits done. It is explained in this document.
17. Did 3rd Party audits take place? (%)
Four audits were conducted on Harvest after code had been deployed. The changes were implemented.
18. Is the bug bounty acceptable high? (%)
Harvest uses Immunefi's active program and offer a max bounty of $200k.
This section covers the documentation of special access controls for a DeFi protocol. The admin access controls are the contracts that allow updating contracts or coefficients in the protocol. Since these contracts can allow the protocol admins to "change the rules", complete disclosure of capabilities is vital for user's transparency. It is explained in this document.
19. Can a user clearly and quickly find the status of the access controls (%)
There is no access control information in the documentation - the only mention of it was found in an article alarming potential users of the single admin key being centralized in the hands of anonymous developers.
20. Is the information clear and complete (%)
No access control information is documented.
21. Is the information in non-technical terms that pertain to the investments (%)
No admin control information was found.
22. Is there Pause Control documentation including records of tests (%)
There is no mention of pause control in the documentation.
1pragma solidity 0.5.16;
2
3import "@openzeppelin/contracts-ethereum-package/contracts/math/Math.sol";
4import "@openzeppelin/contracts-ethereum-package/contracts/math/SafeMath.sol";
5import "@openzeppelin/contracts-ethereum-package/contracts/token/ERC20/SafeERC20.sol";
6import "@openzeppelin/contracts-ethereum-package/contracts/token/ERC20/IERC20.sol";
7import "@openzeppelin/contracts-ethereum-package/contracts/token/ERC20/ERC20.sol";
8import "@openzeppelin/contracts-ethereum-package/contracts/token/ERC20/ERC20Detailed.sol";
9import "./hardworkInterface/IStrategy.sol";
10import "./hardworkInterface/IStrategyV2.sol";
11import "./hardworkInterface/IVault.sol";
12import "./hardworkInterface/IController.sol";
13import "./hardworkInterface/IUpgradeSource.sol";
14import "./ControllableInit.sol";
15import "./VaultStorage.sol";
16
17contract Vault is ERC20, ERC20Detailed, IVault, IUpgradeSource, ControllableInit, VaultStorage {
18 using SafeERC20 for IERC20;
19 using Address for address;
20 using SafeMath for uint256;
21
22 event Withdraw(address indexed beneficiary, uint256 amount);
23 event Deposit(address indexed beneficiary, uint256 amount);
24 event Invest(uint256 amount);
25 event StrategyAnnounced(address newStrategy, uint256 time);
26 event StrategyChanged(address newStrategy, address oldStrategy);
27
28 modifier whenStrategyDefined() {
29 require(address(strategy()) != address(0), "Strategy must be defined");
30 _;
31 }
32
33 // Only smart contracts will be affected by this modifier
34 modifier defense() {
35 require(
36 (msg.sender == tx.origin) || // If it is a normal user and not smart contract,
37 // then the requirement will pass
38 !IController(controller()).greyList(msg.sender), // If it is a smart contract, then
39 "This smart contract has been grey listed" // make sure that it is not on our greyList.
40 );
41 _;
42 }
43
44 constructor() public {
45 }
46
47 // the function is name differently to not cause inheritance clash in truffle and allows tests
48 function initializeVault(address _storage,
49 address _underlying,
50 uint256 _toInvestNumerator,
51 uint256 _toInvestDenominator
52 ) public initializer {
53 require(_toInvestNumerator <= _toInvestDenominator, "cannot invest more than 100%");
54 require(_toInvestDenominator != 0, "cannot divide by 0");
55
56 ERC20Detailed.initialize(
57 string(abi.encodePacked("FARM_", ERC20Detailed(_underlying).symbol())),
58 string(abi.encodePacked("f", ERC20Detailed(_underlying).symbol())),
59 ERC20Detailed(_underlying).decimals()
60 );
61 ControllableInit.initialize(
62 _storage
63 );
64
65 uint256 underlyingUnit = 10 ** uint256(ERC20Detailed(address(_underlying)).decimals());
66 uint256 implementationDelay = 12 hours;
67 uint256 strategyChangeDelay = 12 hours;
68 VaultStorage.initialize(
69 _underlying,
70 _toInvestNumerator,
71 _toInvestDenominator,
72 underlyingUnit,
73 implementationDelay,
74 strategyChangeDelay
75 );
76 }
77
78 function strategy() public view returns(address) {
79 return _strategy();
80 }
81
82 function underlying() public view returns(address) {
83 return _underlying();
84 }
85
86 function underlyingUnit() public view returns(uint256) {
87 return _underlyingUnit();
88 }
89
90 function vaultFractionToInvestNumerator() public view returns(uint256) {
91 return _vaultFractionToInvestNumerator();
92 }
93
94 function vaultFractionToInvestDenominator() public view returns(uint256) {
95 return _vaultFractionToInvestDenominator();
96 }
97
98 function nextImplementation() public view returns(address) {
99 return _nextImplementation();
100 }
101
102 function nextImplementationTimestamp() public view returns(uint256) {
103 return _nextImplementationTimestamp();
104 }
105
106 function nextImplementationDelay() public view returns(uint256) {
107 return _nextImplementationDelay();
108 }
109
110 /**
111 * Chooses the best strategy and re-invests. If the strategy did not change, it just calls
112 * doHardWork on the current strategy. Call this through controller to claim hard rewards.
113 */
114 function doHardWork() external whenStrategyDefined onlyControllerOrGovernance {
115 uint256 sharePriceBeforeHardWork = getPricePerFullShare();
116 if (_withdrawBeforeReinvesting()) {
117 IStrategy(strategy()).withdrawAllToVault();
118 }
119
120 // ensure that new funds are invested too
121 invest();
122 IStrategy(strategy()).doHardWork();
123 uint256 sharePriceAfterHardWork = getPricePerFullShare();
124
125 if (!allowSharePriceDecrease()) {
126 require(sharePriceBeforeHardWork <= sharePriceAfterHardWork, "Share price should not decrease");
127 }
128 }
129
130 /*
131 * Returns the cash balance across all users in this contract.
132 */
133 function underlyingBalanceInVault() view public returns (uint256) {
134 return IERC20(underlying()).balanceOf(address(this));
135 }
136
137 /* Returns the current underlying (e.g., DAI's) balance together with
138 * the invested amount (if DAI is invested elsewhere by the strategy).
139 */
140 function underlyingBalanceWithInvestment() view public returns (uint256) {
141 if (address(strategy()) == address(0)) {
142 // initial state, when not set
143 return underlyingBalanceInVault();
144 }
145 return underlyingBalanceInVault().add(IStrategy(strategy()).investedUnderlyingBalance());
146 }
147
148 function getPricePerFullShare() public view returns (uint256) {
149 return totalSupply() == 0
150 ? underlyingUnit()
151 : underlyingUnit().mul(underlyingBalanceWithInvestment()).div(totalSupply());
152 }
153
154 function getEstimatedWithdrawalAmount(uint256 numberOfShares) public view returns (uint256 realTimeCalculatedValue) {
155 return numberOfShares.mul(getPricePerFullShare()).div(underlyingUnit());
156 }
157
158 function underlyingBalanceWithInvestmentForHolder(address holder) view external returns (uint256) {
159 // for compatibility
160 uint256 estimatedWithdrawal = getEstimatedWithdrawalAmount(balanceOf(holder));
161 return estimatedWithdrawal;
162 }
163
164 function futureStrategy() public view returns (address) {
165 return _futureStrategy();
166 }
167
168 function strategyUpdateTime() public view returns (uint256) {
169 return _strategyUpdateTime();
170 }
171
172 function strategyTimeLock() public view returns (uint256) {
173 return _strategyTimeLock();
174 }
175
176 function canUpdateStrategy(address _strategy) public view returns(bool) {
177 return strategy() == address(0) // no strategy was set yet
178 || (_strategy == futureStrategy()
179 && block.timestamp > strategyUpdateTime()
180 && strategyUpdateTime() > 0); // or the timelock has passed
181 }
182
183 /**
184 * Indicates that the strategy update will happen in the future
185 */
186 function announceStrategyUpdate(address _strategy) public onlyControllerOrGovernance {
187 // records a new timestamp
188 uint256 when = block.timestamp.add(strategyTimeLock());
189 _setStrategyUpdateTime(when);
190 _setFutureStrategy(_strategy);
191 emit StrategyAnnounced(_strategy, when);
192 }
193
194 /**
195 * Finalizes (or cancels) the strategy update by resetting the data
196 */
197 function finalizeStrategyUpdate() public onlyControllerOrGovernance {
198 _setStrategyUpdateTime(0);
199 _setFutureStrategy(address(0));
200 }
201
202 function setStrategy(address _strategy) public onlyControllerOrGovernance {
203 require(canUpdateStrategy(_strategy),
204 "The strategy exists and switch timelock did not elapse yet");
205 require(_strategy != address(0), "new _strategy cannot be empty");
206 require(IStrategy(_strategy).underlying() == address(underlying()), "Vault underlying must match Strategy underlying");
207 require(IStrategy(_strategy).vault() == address(this), "the strategy does not belong to this vault");
208
209 emit StrategyChanged(_strategy, strategy());
210 if (address(_strategy) != address(strategy()) {
211 if (address(strategy()) != address(0)) { / if the original strategy (no underscore) is defined
212 IERC20(underlying()).safeApprove(address(strategy()), 0);
213 IStrategy(strategy()).withdrawAllToVault();
214 }
215 _setStrategy(_strategy);
216 IERC20(underlying()).safeApprove(address(strategy()), 0);
217 IERC20(underlying()).safeApprove(address(strategy()), uint256(~0));
218 }
219 finalizeStrategyUpdate();
220 }
221
222 function setVaultFractionToInvest(uint256 numerator, uint256 denominator) external onlyGovernance {
223 require(denominator > 0, "denominator must be greater than 0");
224 require(numerator <= denominator, "denominator must be greater than or equal to the numerator");
225 _setVaultFractionToInvestNumerator(numerator);
226 _setVaultFractionToInvestDenominator(denominator);
227 }
228
229 function setWithdrawBeforeReinvesting(bool value) external onlyGovernance {
230 _setWithdrawBeforeReinvesting(value);
231 }
Comments to Code: 1271 / 2939 = 43 %
Tests to Code: 11333 / 2939 = 386 %