If you notice some outdated information please let us know!
PASS
The final review score is indicated as a percentage. The percentage is calculated as Achieved Points due to MAX Possible Points. For each element the answer can be either Yes/No or a percentage. For a detailed breakdown of the individual weights of each question, please consult this document.
Very simply, the audit looks for the following declarations from the developer's site. With these declarations, it is reasonable to trust the smart contracts.
This report is for informational purposes only and does not constitute investment advice of any kind, nor does it constitute an offer to provide investment advisory or other services. Nothing in this report shall be considered a solicitation or offer to buy or sell any security, token, future, option or other financial instrument or to offer or provide any investment advice or service to any person in any jurisdiction. Nothing contained in this report constitutes investment advice or offers any opinion with respect to the suitability of any security, and the views expressed in this report should not be taken as advice to buy, sell or hold any security. The information in this report should not be relied upon for the purpose of investing. In preparing the information contained in this report, we have not taken into account the investment needs, objectives and financial circumstances of any particular investor. This information has no regard to the specific investment objectives, financial situation and particular needs of any specific recipient of this information and investments discussed may not be suitable for all investors.
Any views expressed in this report by us were prepared based upon the information available to us at the time such views were written. The views expressed within this report are limited to DeFiSafety and the author and do not reflect those of any additional or third party and are strictly based upon DeFiSafety, its authors, interpretations and evaluation of relevant data. Changed or additional information could cause such views to change. All information is subject to possible correction. Information may quickly become unreliable for various reasons, including changes in market conditions or economic circumstances.
This completed report is copyright (c) DeFiSafety 2023. Permission is given to copy in whole, retaining this copyright label.
This section looks at the code deployed on the Mainnet that gets reviewed and its corresponding software repository. The document explaining these questions is here.
1. Are the executing code addresses readily available? (%)
They are available at website https://protocol.0x.org/en/latest/basics/addresses.html, as indicated in the Appendix.
2. Is the code actively being used? (%)
Activity is over 10 transactions a day on contract ZeroEx.sol, as indicated in the Appendix.
3. Is there a public software repository? (Y/N)
Is there a public software repository with the code at a minimum, but also normally test and scripts. Even if the repository was created just to hold the files and has just 1 transaction, it gets a "Yes". For teams with private repositories, this answer is "No"
4. Is there a development history visible? (%)
With 16,743 commits and 66 branches, 0x Protocol's main GitHub repository has a great development history.
This metric checks if the software repository demonstrates a strong steady history. This is normally demonstrated by commits, branches and releases in a software repository. A healthy history demonstrates a history of more than a month (at a minimum).
5. Is the team public (not anonymous)? (Y/N)
Location: https://0x.org/about/team.
For a "Yes" in this question, the real names of some team members must be public on the website or other documentation (LinkedIn, etc). If the team is anonymous, then this question is a "No".
This section looks at the software documentation. The document explaining these questions is here.
7. Are the basic software functions documented? (Y/N)
All of the 0x Protocol basic software functions are documented in https://protocol.0x.org/en/latest/basics/orders.html.
8. Does the software function documentation fully (100%) cover the deployed contracts? (%)
0x's software documentation covers all of their deployed contracts in the "Basics", "Advanced", "Architecture", and "Tokenomics" sections.
9. Are there sufficiently detailed comments for all functions within the deployed contract code (%)
The Comments to Code (CtC) ratio is the primary metric for this score.
10. Is it possible to trace from software documentation to the implementation in code (%)
There is clear and explicit traceability between the documented 0x software functions and their implementation in the protocol's source code. This can be seen in the "Architecture" section of their documentation.
11. Full test suite (Covers all the deployed code) (%)
This score is guided by the Test to Code ratio (TtC). Generally a good test to code ratio is over 100%. However the reviewers best judgement is the final deciding factor.
12. Code coverage (Covers all the deployed lines of code, or explains misses) (%)
0x Protocol has 80% code coverage with coveralls at https://coveralls.io/github/0xProject/0x-monorepo?branch=development.
13. Scripts and instructions to run the tests? (Y/N)
Scripts/Instructions location: https://github.com/0xProject/protocol/blob/development/README.md.
14. Report of the results (%)
There is a GitHub code coverage report available at https://coveralls.io/builds/31242763.
15. Formal Verification test done (%)
There is no evidence that a 0x Protocol Formal Verification test has been performed.
16. Stress Testing environment (%)
There is evidence of 0x Protocol's testnet smart contract usage at https://0x.org/docs/guides/0x-cheat-sheet#mainnet-1-1.
This section looks at the 3rd party software audits done. It is explained in this document.
17. Did 3rd Party audits take place? (%)
0x Protocol has had multiple audits performed on their various mainnet launches for their exchange and staking contracts. Multiple of these had been performed pre launch at https://protocol.0x.org/en/latest/additional/audits.html.
18. Is the bug bounty acceptable high? (%)
0x Protocol's Bug Bounty program offers a maximum of 100k for the most critical of findings.
This section covers the documentation of special access controls for a DeFi protocol. The admin access controls are the contracts that allow updating contracts or coefficients in the protocol. Since these contracts can allow the protocol admins to "change the rules", complete disclosure of capabilities is vital for user's transparency. It is explained in this document.
19. Can a user clearly and quickly find the status of the access controls (%)
0x Protocol's access control information can easily be found in their "Core Concepts" section at https://0x.org/docs/core-concepts#a-non-custodial-exchange-protocol, as well as in their "Contracts" section at https://protocol.0x.org/en/latest/architecture/governor.html#managing-ownership.
20. Is the information clear and complete (%)
All of the contracts that have access to user funds are immutable, and this is clearly explained at https://0x.org/docs/core-concepts#a-non-custodial-exchange-protocol.
21. Is the information in non-technical terms that pertain to the investments (%)
All of the contracts that have access to user funds are immutable, and this is clearly explained at https://0x.org/docs/core-concepts#a-non-custodial-exchange-protocol.
22. Is there Pause Control documentation including records of tests (%)
Pause Control is clearly explained at https://protocol.0x.org/en/latest/additional/emergency.html, but there is no evidence of regular tests.
1/// @dev An extensible proxy contract that serves as a universal entry point for
2/// interacting with the 0x protocol.
3contract ZeroEx {
4 // solhint-disable separate-by-one-line-in-contract,indent,var-name-mixedcase
5 using LibBytesV06 for bytes;
6
7 /// @dev Construct this contract and register the `BootstrapFeature` feature.
8 /// After constructing this contract, `bootstrap()` should be called
9 /// by `bootstrap()` to seed the initial feature set.
10 /// @param bootstrapper Who can call `bootstrap()`.
11 constructor(address bootstrapper) public {
12 // Temporarily create and register the bootstrap feature.
13 // It will deregister itself after `bootstrap()` has been called.
14 BootstrapFeature bootstrap = new BootstrapFeature(bootstrapper);
15 LibProxyStorage.getStorage().impls[bootstrap.bootstrap.selector] =
16 address(bootstrap);
17 }
18
19 // solhint-disable state-visibility
20
21 /// @dev Forwards calls to the appropriate implementation contract.
22 fallback() external payable {
23 bytes4 selector = msg.data.readBytes4(0);
24 address impl = getFunctionImplementation(selector);
25 if (impl == address(0)) {
26 _revertWithData(LibProxyRichErrors.NotImplementedError(selector));
27 }
28
29 (bool success, bytes memory resultData) = impl.delegatecall(msg.data);
30 if (!success) {
31 _revertWithData(resultData);
32 }
33 _returnWithData(resultData);
34 }
35
36 /// @dev Fallback for just receiving ether.
37 receive() external payable {}
38
39 // solhint-enable state-visibility
40
41 /// @dev Get the implementation contract of a registered function.
42 /// @param selector The function selector.
43 /// @return impl The implementation contract address.
44 function getFunctionImplementation(bytes4 selector)
45 public
46 view
47 returns (address impl)
48 {
49 return LibProxyStorage.getStorage().impls[selector];
50 }
51
52 // @dev Revert with arbitrary bytes.
53 // @param data Revert data.
54 function _revertWithData(bytes memory data) private pure {
55 assembly { revert(add(data, 32), mload(data)) }
56 }
57
58 // @dev Return with arbitrary bytes.
59 /// @param data Return data.
60 function _returnWithData(bytes memory data) private pure {
61 assembly { return(add(data, 32), mload(data)) }
62 }
63}
Comments to Code: 575 / 999 = 58 %
Tests to Code: 16336 / 999 = 1635 %