If you notice some outdated information please let us know!
FAIL
The final review score is indicated as a percentage. The percentage is calculated as Achieved Points due to MAX Possible Points. For each element the answer can be either Yes/No or a percentage. For a detailed breakdown of the individual weights of each question, please consult this document.
Very simply, the audit looks for the following declarations from the developer's site. With these declarations, it is reasonable to trust the smart contracts.
This report is for informational purposes only and does not constitute investment advice of any kind, nor does it constitute an offer to provide investment advisory or other services. Nothing in this report shall be considered a solicitation or offer to buy or sell any security, token, future, option or other financial instrument or to offer or provide any investment advice or service to any person in any jurisdiction. Nothing contained in this report constitutes investment advice or offers any opinion with respect to the suitability of any security, and the views expressed in this report should not be taken as advice to buy, sell or hold any security. The information in this report should not be relied upon for the purpose of investing. In preparing the information contained in this report, we have not taken into account the investment needs, objectives and financial circumstances of any particular investor. This information has no regard to the specific investment objectives, financial situation and particular needs of any specific recipient of this information and investments discussed may not be suitable for all investors.
Any views expressed in this report by us were prepared based upon the information available to us at the time such views were written. The views expressed within this report are limited to DeFiSafety and the author and do not reflect those of any additional or third party and are strictly based upon DeFiSafety, its authors, interpretations and evaluation of relevant data. Changed or additional information could cause such views to change. All information is subject to possible correction. Information may quickly become unreliable for various reasons, including changes in market conditions or economic circumstances.
This completed report is copyright (c) DeFiSafety 2023. Permission is given to copy in whole, retaining this copyright label.
This section looks at the code deployed on the Mainnet that gets reviewed and its corresponding software repository. The document explaining these questions is here.
1. Are the executing code addresses readily available? (%)
Executing addresses could not be found on the website, Documentation, or Github. There has been NO official developer-supported documentation that has included any Smart Contract Addresses in their documentation. A contract address was found from a medium article, which is not affiliated with the site, but our process requires the protocol to publish their addresses. For this reason the score is 0%. As per our process, this means that the audit score is 0% also (See Q17).
2. Is the code actively being used? (%)
Activity exceeds 300 transactions a day as indicated in the Appendix.
3. Is there a public software repository? (Y/N)
ShibaSwap has a private GitHub repository.
Is there a public software repository with the code at a minimum, but also normally test and scripts. Even if the repository was created just to hold the files and has just 1 transaction, it gets a "Yes". For teams with private repositories, this answer is "No"
4. Is there a development history visible? (%)
ShibaSwap has a Private Development Repository.
This metric checks if the software repository demonstrates a strong steady history. This is normally demonstrated by commits, branches and releases in a software repository. A healthy history demonstrates a history of more than a month (at a minimum).
5. Is the team public (not anonymous)? (Y/N)
No public team members.
For a "Yes" in this question, the real names of some team members must be public on the website or other documentation (LinkedIn, etc). If the team is anonymous, then this question is a "No".
This section looks at the software documentation. The document explaining these questions is here.
6. Is there a whitepaper? (Y/N)
7. Are the basic software functions documented? (Y/N)
No software function documentation was found in any official developer-supported documentation.
8. Does the software function documentation fully (100%) cover the deployed contracts? (%)
No software function documentation was found in any official developer-supported documentation.
9. Are there sufficiently detailed comments for all functions within the deployed contract code (%)
ShibaSwap has a Comment to Code ratio of 24%.
The Comments to Code (CtC) ratio is the primary metric for this score.
10. Is it possible to trace from software documentation to the implementation in code (%)
No software documentation in any official developer-supported documentation.
11. Full test suite (Covers all the deployed code) (%)
There are no tests or test reports that are publicly available in any official developer-supported documentation, resources, or github.
This score is guided by the Test to Code ratio (TtC). Generally a good test to code ratio is over 100%. However the reviewers best judgement is the final deciding factor.
12. Code coverage (Covers all the deployed lines of code, or explains misses) (%)
There was no indication of any code coverage test having been done that were then published in any official developer-supported documentation channels.
13. Scripts and instructions to run the tests? (Y/N)
There are no ShibaSwap tests availible publicly, and there is NO official developer-supported documentation with any scripts and installations available.
14. Report of the results (%)
There are NO official developer-supported documentation that include any report of the test resuts.
15. Formal Verification test done (%)
There is NO official developer-supported documentation that indicates that any formal verification testing has been done.
16. Stress Testing environment (%)
There is NO official developer-supported documentation that indicates that any Kovan or Ropsten TestNet addresses are availible.
This section looks at the 3rd party software audits done. It is explained in this document.
17. Did 3rd Party audits take place? (%)
Certik released an audit on 2021/07/27 of ShibaSwap. It is a solid auditwith changes implemented before deployment. It has 34 findings which is higher than normal. The audit highlights very high centralization risk through the multisigs, which have control of user funds.
18. Is the bug bounty acceptable high? (%)
No ShibaSwap Bug Bounty program was found.
This section covers the documentation of special access controls for a DeFi protocol. The admin access controls are the contracts that allow updating contracts or coefficients in the protocol. Since these contracts can allow the protocol admins to "change the rules", complete disclosure of capabilities is vital for user's transparency. It is explained in this document.
19. Can a user clearly and quickly find the status of the access controls (%)
The highly centralized status of the access controls is detailed in the Certik audit. The multisig has very high control.
20. Is the information clear and complete (%)
b) Multisig function is clearly outlined in the ShibaSwap whitepaper. (30%) c) The capabilities for change are described clearly in the audit. (30%)
21. Is the information in non-technical terms that pertain to the investments (%)
Guidance: 100% All the contracts are immutable 90% Description relates to investments safety and updates in clear, complete non-software l language 30% Description all in software specific language 0% No admin control information could not be found
22. Is there Pause Control documentation including records of tests (%)
No Pause Control or similar function is listed in the ShibaSwap documentation.
1
2 / function to claim all the tokens locked by user, after the locking period
3 function claimAll(uint256 r) external {
4 claimAllForUser(r, msg.sender);
5 }
6
7 / function to get claimable amount for any user
8 function getClaimableAmount(address _user) external view returns(uint256) {
9 LockInfo[] memory lockInfoArrayForUser = lockInfoByUser[_user];
10 uint256 totalTransferableAmount = 0;
11 uint i;
12 for (i=latestCounterByUser[_user]; i<lockInfoArrayForUser.length; i++){
13 uint256 lockingPeriodHere = lockingPeriod;
14 if(lockInfoArrayForUser[i]._isDev){
15 lockingPeriodHere = devLockingPeriod;
16 }
17 if(now >= (lockInfoArrayForUser[i]._timestamp.add(lockingPeriodHere))){
18 totalTransferableAmount = totalTransferableAmount.add(lockInfoArrayForUser[i]._amount);
19 } else {
20 break;
21 }
22 }
23 return totalTransferableAmount;
24 }
25
26 // get the left and right headers for a user, left header is the index counter till which we have already iterated, right header is basically the length of user's lockInfo array
27 function getLeftRightCounters(address _user) external view returns(uint256, uint256){
28 return(latestCounterByUser[_user], lockInfoByUser[_user].length);
29 }
30
31 // in cases of emergency, emergency address can set this to true, which will enable emergencyWithdraw function
32 function setEmergencyFlag(bool _emergencyFlag) external {
33 require(msg.sender == emergencyAddress, "This function can only be called by emergencyAddress");
34 emergencyFlag = _emergencyFlag;
35 }
36
37 // function for owner to transfer all tokens to another address
38 function emergencyWithdrawOwner(address _to) external onlyOwner{
39 uint256 amount = boneToken.balanceOf(address(this));
40 require(boneToken.transfer(_to, amount), 'MerkleDistributor: Transfer failed.');
41 }
42
43 // emergency address can be updated from here
44 function setEmergencyAddr(address _newAddr) external {
45 require(msg.sender == emergencyAddress, "This function can only be called by emergencyAddress");
46 require(_newAddr != address(0), "_newAddr is a zero address");
47 emergencyAddress = _newAddr;
48 }
49
50 // function to update/change the normal & dev locking period
51 function setLockingPeriod(uint256 _newLockingPeriod, uint256 _newDevLockingPeriod) external onlyOwner {
52 lockingPeriod = _newLockingPeriod;
53 devLockingPeriod = _newDevLockingPeriod;
54 emit LockingPeriod(msg.sender, _newLockingPeriod, _newDevLockingPeriod);
55 }
56}
57
Comments to Code: 132 / 560 = 24 %